From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 370E83858413 for ; Thu, 17 Mar 2022 18:45:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 370E83858413 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-0QlcEcnZMOqJgkA8jM8yeg-1; Thu, 17 Mar 2022 14:45:48 -0400 X-MC-Unique: 0QlcEcnZMOqJgkA8jM8yeg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D6721066542; Thu, 17 Mar 2022 18:45:48 +0000 (UTC) Received: from [10.2.17.71] (unknown [10.2.17.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E337A112C08C; Thu, 17 Mar 2022 18:45:47 +0000 (UTC) Message-ID: <1c8c2931-cb11-61dd-24d4-a30a1985e3ad@redhat.com> Date: Thu, 17 Mar 2022 11:45:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/5] [func_call] Add possible spelling of linker error message. To: "Metzger, Markus T" , "Hannula, Ari" Cc: Tim Wiederhake , "gdb-patches@sourceware.org" References: <20220210135243.3127629-1-ari.hannula@intel.com> <20220210135243.3127629-2-ari.hannula@intel.com> From: Keith Seitz In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 18:45:51 -0000 On 3/17/22 10:58, Metzger, Markus T wrote: > Hello Ari, > >> Seen with RHEL 7.5 and Fedora 26. >> Is there a little more that can be said? I gather this patch is desired because the error message is simply different on some systems? >> gdb/testsuite/ChangeLog: >> 2019-02-18 Tim Wiederhake >> >> * lib/gdb.exp (gdb_compile_pthreads): Add new error regexp. >> As mentioned, you can drop these ChangeLog entries. >> Signed-off-by: Tim Wiederhake >> Signed-off-by: Ari Hannula >> --- >> gdb/testsuite/lib/gdb.exp | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index a3717a4022..363289caa1 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -4618,6 +4618,9 @@ proc gdb_compile_pthreads {source dest type options} >> { >> set why_msg "missing threads include file" >> break >> } >> + ".*cannot find -lpthread.*" { >> + set why_msg "missing runtime threads library" >> + } >> ".*cannot open -lpthread.*" { >> set why_msg "missing runtime threads library" >> } If these are truly the same error condition, then since this switch statement uses regexp-matching, we should be able to merge the two "missing runtime threads library" cases with "(find|open)". If they are actually different errors, I'd like to see `why_msg' reflect the distinction. > LGTM but you need Keith or a global maintainer to approve this. This otherwise looks okay to me, too, but I am unable to officially approve patches. Keith