From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2047.outbound.protection.outlook.com [40.107.115.47]) by sourceware.org (Postfix) with ESMTPS id 63106385770F for ; Thu, 18 May 2023 18:44:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63106385770F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aot8bjfv9k8il4D9f8eZB7ZeLOHTN5uPQGoGpPjhYLddmjQItNZNxykfjP0z6iJfd6EAW/lrZqMP1OMhM3qpOBbA+VWm7hIetQbW47hv9LyjOW2tHHJrKAVg8zZrxNm50PbTxyGBmQtFafvniXJmpAEt/pr8jZYKiS9aeQVKacJi5Q9HpcYLVOQiBYMABDaQM+PaIdhfiHQHx5XQkqPEL6nlQT5HlxgXLazLj19I6Jui697JkLonXPG2LTs7rC+ADSvkh16cR0uAm351sjT0XqAVLQbU1b+rtO3kr8sB3CXdN/vcJf5sxwEwZ81pNYpUHW/0NkBEQEWJ5WS3herkEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Iajg4KfY6Gd1Lg0vtUil8pK/7W9RKcZiCwulwgyzQ6Q=; b=nQFeefKQKxDOda6ZFVEWMRhRBpMvRxKuWlsaZKyWh5pDbP0fpcasQGirSiS6IiIy5CDbTUwo0ENWqFuswRoO1puRmXouRmyUMLRwv+XsyNgr6LXBEUERu6WjjbGo66PPf/V9l3dI88MC7A7RSxcF5Ndzn+GVGGEEE+36ewp+B386wac1PLL1+pEP6Rm5mj7bA6B6URmaUwIscN5lco1V4+tXqKGhEqK5mt8YqKsGiXXUDRLmdPodYG8+6GO6uN74G8cJ0zr273IGV1F4+EbGzViuzMLuWltgGiUZIYAzj8qnQnac6+hjAW/vYYA0FS94qzwjkF0c/YZOgMjc+JMxPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Iajg4KfY6Gd1Lg0vtUil8pK/7W9RKcZiCwulwgyzQ6Q=; b=dKthflif6S0wdkwsWSswHCBMkYJWAV6fAHK1+gkXx5Qce7L5SJOmiT0X2k0ah9Q7YXDcp/8hJU2v7mPH+1yMSJCrwCq0Kv47ocoWS11dCu+cxGvPkn/u5+B1K+kovTjTIu/qs2GV++CF/HCgsl6xXaVD8loE95sTahUVdVBQTGYNA6odIbCLus8MQ0kLWtEZNSsSmyYftfjafzJg55hFnDfyAgSBzVhtQLZt2sndyHf2tk6s3hROma3dlnPr3Fe0o/3nTroTJpYvZ4GPbPJv8efyMEQSwnWJsQuYorFRWnr15+bpEVAvhlM8YHBicPqKpgHOS7bkLUebj8mJ6WlzIw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YQBPR0101MB8544.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:57::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 18:44:44 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::b7c2:2912:524e:8e80]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::b7c2:2912:524e:8e80%6]) with mapi id 15.20.6411.019; Thu, 18 May 2023 18:44:44 +0000 Message-ID: <1c9c1df1-5c2e-9981-a911-bb5e9188e39e@efficios.com> Date: Thu, 18 May 2023 14:44:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 12/12] gdb: remove breakpoint_pointer_iterator Content-Language: fr To: Andrew Burgess , Simon Marchi via Gdb-patches References: <20230511144832.17974-1-simon.marchi@efficios.com> <20230511144832.17974-13-simon.marchi@efficios.com> <877ct5ab5c.fsf@redhat.com> From: Simon Marchi In-Reply-To: <877ct5ab5c.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0171.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:f::14) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YQBPR0101MB8544:EE_ X-MS-Office365-Filtering-Correlation-Id: 92f5492e-fd9a-4c6c-91c5-08db57cff2a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C3p+UrOffKWcdHACLto1usITn5f5nMT+fE+z6MuCZgmgJtdfq8YMYD9SIUVmVtkbc3mo9BMtkY+TVOJdL1PE8zhywQUilqR1YTN3AhPW0LNi5p1xZm0QLlnmTC0wWjNApFYH0CJ/eBFVIhd1d7OWz7HJfoRVrD4ew4YnW/zpnjiRxzENTBFQX06kEy0ho3ceTXIdgkxJG/expSyDDoxSpAafQOmQIrqVx6q7A7yiatDrcjmHcTpw4k2HZY3oX8hZ22OjFWFAtVGjnFmeINC0Hkni5IHCQgQcnYFiqExA99zdMFZn9CCg1ufiVNlkyeAudyH8OY/tYDKle4PlQjphU+/DeowfBiYmwmV7ACwiDd0JCWOpPk/Ila/vydgQW/3unWyslv+n+B+zpPTvxp10CnPEeb0W8POzO3IXUAykTeuXa2Ub1sT9jmMoVQjBJyZwO+cFQBsXESKz6hZ7B0t/QKZaOi49cxWXq9/26VLs/iHoAbBtGZIeXEhjaR5bJQ/v3/0BxthC9yVMYpodRzFO7NFtPKP3C7IRr1BCoWVVZg9Ro19vKY3ZWezfXio2n+9afw1mFUkBoP48w7RiOwYazNVT8k48dKUVEAZDiTS5XmIAdMYLZ6TAARJ+JiF/R7T2Xky/pp2x3R+sX3fb6+WRbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(39830400003)(396003)(376002)(136003)(346002)(366004)(451199021)(2906002)(8936002)(478600001)(41300700001)(8676002)(31686004)(316002)(44832011)(110136005)(6486002)(66946007)(66476007)(66556008)(5660300002)(6506007)(6512007)(26005)(186003)(38100700002)(2616005)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU1CVmdxcWw0ZktNYnBNZVZrOWFsMGZxV3prQm1qQXdwYXloUkdPQUdtK3pm?= =?utf-8?B?UWRBOUNmaXBBNmlvWkYzOWNTaHNWZ1V6aEtEbFJXd3RSbWowaGdod3c5aHhx?= =?utf-8?B?S2tnbDlOdHRINy8zanNQbDJTNTRaYzEwWEtpYWw2dGtmVnJQOFZzQ2JlRExa?= =?utf-8?B?NWRUdjlaRk1kN2ZYMm9JR2pyd2pWRnhVQldIUjhyZGhhYnhBTnFEOWtERktS?= =?utf-8?B?SlZNMnNFWm1UTmc2YmJNK1FmcHdkV1dZU1IzdFpVSG1mTzdjRzRWT3JrMlZK?= =?utf-8?B?MTNHK3pSMjRKakcwM1drYWJTRmt2cUF3cWpnUm1xSVFUQVpEaFhMSmN4bTNR?= =?utf-8?B?QnBmaWpOUGN5TEpYWFRmMmtpVU9XUjc3a21UR1VMMmdIVDBFNmRKdmpwSkg5?= =?utf-8?B?a1lCb2FlM2taRThYakhtMVUvMEhvSisvWmlpak1hM0t6ZGFIOWVoQjV4TWs3?= =?utf-8?B?cUZjNGVmOFhKcDMvMkdHZXQ5T1c0dDFxNnpvdmxpbklSZHY4b0ltNWFSelBp?= =?utf-8?B?Wk1sVHNWSmpHMmNRc3FJK1BrR2IyVklLY214b0h1SG4rVVBkempSSVFaMGt4?= =?utf-8?B?bDFOVUFmM3IwbzJXVmc1blRLNElPdVNCZDV5cGNYQ2pGVzZMd1FLZE1maVps?= =?utf-8?B?WnhwWVFvTDlOWC9sOFJBektwRnNRdUNvMFd4Z2p2NUJUZUM4N1gwQVZSOUV1?= =?utf-8?B?a0ZKYzJKSEZnekJWV21sZ3hoYlVtd29aRG03VkVYbXd3a29RWS9LNXNRaTRo?= =?utf-8?B?dWlqNGdQTlE0WFNqeFNwU2NZWWJBaHl6R3VnajdGY1g0TlcxSDFRU3c1TFBm?= =?utf-8?B?dnJrMGQrSHpJRkdUT3B2SFdTSjF4VGRRN0ovSG5nbXpiQTFudisyL1VPYnZG?= =?utf-8?B?Y2dpY3dqZ3BjSFFOdDZqbkNjeXhDUzRucmZ3bEcvSGRlSkQvRHpDNzdpOG5Z?= =?utf-8?B?ejF3ajExZjh4cGhhYU8vUjhLVE81ZUh3OWJDeWpvQ29ZTkZTSzdyMDRRejE2?= =?utf-8?B?SUZYb004dGVEYlpBdE0yV001eVhXbGdIdGE4NmpodVJCUFU1dmxBNUFFaUVp?= =?utf-8?B?bjArdmhKT1JnM2dLaUFQd1E0Nzk4T3lqNFVKckZtZG4yQ1lyOWVSWS93aDhj?= =?utf-8?B?TldqdkNnTEorRVdBOGRlMjJRdXQ2cTRKNnZWOTZqVVNpWnlzaVdUWTRXQVgy?= =?utf-8?B?bEZRM01XQmF3MFJMWUdmUld2bWh0MUVtNTFrNmtuS2crN2dYc0FOUkNsRkNh?= =?utf-8?B?dUZsKzFVN2M5NGw4U2d6dURRdmVQQ1h6RUNoL1lEMnZXQjh1bXdzQmZ6dVF3?= =?utf-8?B?VzRpUkJCbHBOWHpRUXh1WHRMQk1reWMxQ2VibEpTOTlRZ0tTQXpIcWJXck5R?= =?utf-8?B?UXhFMXBDY0N4QjBLNUs0UzI4SlQrbWpnWE5ZWUNkU3pFblRTQ3JXdG0rd0l4?= =?utf-8?B?NGIrMWFnZmhYMnlDdEhzWEQyOFg3WnYvSXFicUdVWG5mZmhXUHE1U0R1MENo?= =?utf-8?B?N1luUlczM1A0NUg2elZaZmkvUXhmVkxiMGthK0k3azJhaTQ4cUVCaU9FV0NE?= =?utf-8?B?cnRpbmxicmpuazhJanhoaFFGa29HdGt5Wlc3c2xFcG9rQmZLK0VvVVloL3BI?= =?utf-8?B?NFZ3aXVLYUJDUlgwb1BBaTBZOERxRlI4RXZjdis0WCtIT01YSkdMd2l3ZjlE?= =?utf-8?B?VERNRU1yVXpmc3o2c2xwaEIzNU5zNFNRNU9xcTVGR1VZNGU4WmlMZ3NYb2ZZ?= =?utf-8?B?RGphNnI4YnlEYmszdVc5ZlZTdzc5cFVpY0xlelg4NXNQU0VkclNkV2NtT01S?= =?utf-8?B?MXdYbGlDQW50TDEvUFJHNnFHWUp2ZnFsTFZCUmlrejM0OEY1WGVCNHByeFdT?= =?utf-8?B?WnBkYm42QTRDam5VMzFPd1p3cmNlVWhUNjIyanlscGNtOThVSnFzdXovdVZp?= =?utf-8?B?OUR5Wm1XL014Y2x4ek5iZTUvVUE1NEgycyt1WXA4cGFzVFdUR0dkMk5GQXcr?= =?utf-8?B?Mml6SkJ1SjdteTNpdUJ1Ukh4eEJQc2hUV2ZnbXlRdHZsdjBBSDg3NkZxV2Fp?= =?utf-8?B?SGN4YVNzMGYyK2IrZG5oU1JoMzI0eWNQMTBaMXdkMmZlL1pETXhpTUJqQzlm?= =?utf-8?Q?RdR0KSB+BdAV4Vj5kkTnRu5RJ?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92f5492e-fd9a-4c6c-91c5-08db57cff2a2 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 18:44:44.5011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J7fQexs8NxJaWIDUF+MIOwb4CaxdB+XEfnIOPBjsDE6gBpT1tsiMY+l+2mYXwAZoinFzyzC99CKeDuDjCe46aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB8544 X-Spam-Status: No, score=-3040.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> @@ -3055,12 +3052,12 @@ breakpoint_program_space_exit (struct program_space *pspace) >> void >> insert_breakpoints (void) >> { >> - for (breakpoint *bpt : all_breakpoints ()) >> - if (is_hardware_watchpoint (bpt)) >> + for (breakpoint &bpt : all_breakpoints ()) >> + if (is_hardware_watchpoint (&bpt)) >> { >> - struct watchpoint *w = (struct watchpoint *) bpt; >> + watchpoint &w = static_cast (bpt); > > Could possibly use gdb::checked_static_cast here? And in other places > throughout this patch? checked_static_cast doesn't work with references though... so I would have to write: watchpoint &w = *gdb::checked_static_cast (&bpt); Do you think it's possible to make checked_static_cast work for references? I'll give it a try. >> diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h >> index a03b57734b9d..c0d73d374cb0 100644 >> --- a/gdb/breakpoint.h >> +++ b/gdb/breakpoint.h > > In patch #7 you added: > > #include "gdbsupport/reference-to-pointer-iterator.h" > > Is this still needed after this patch? I haven't checked, but it feels > like maybe it could be removed now. Yep removed. Simon