From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by sourceware.org (Postfix) with ESMTPS id 385343939C16 for ; Tue, 19 Jan 2021 17:44:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 385343939C16 Received: by mail-qt1-x833.google.com with SMTP id z6so7243258qtn.0 for ; Tue, 19 Jan 2021 09:44:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D0WiVaQ6RlMiKmBYr2GX2N/+AHDvaesVOm6+UDrH2No=; b=pqX3ZshHfTc7aWbRrZgqn/87HDlt5V2rAxCaEauWEBNCGTTBjQE+zz6XyOpzxHSi2j sZQbfVH4fu+EgnfEN1+F8TpFGsl9Xqj8/dBsSDILu2fWITFACpgZCUpCzhCyqdWW3WC6 UhHzJgkEjV2SE/xGa5C5/fkon5q5PUp4VWRYsRVsViKh107GMKizThNSPHDSYGx4pL9W gMaoaSioTdYIk0uOtL+xIlEbu3Hrs5jiAccjcI9M7UidfNB77H1lMW0rC7POi7zq1+d8 fyK7Cg4ln2t2uNCwdIO6Uk0ilu4CBK7HvjVSqY3SS0lTsqLUUL6v2by4Qj9dWeDYdYrR 2YzQ== X-Gm-Message-State: AOAM533szYoHjkSLMXy74//LukMkcJs+7h5TTYycLYmUNLB7GwT+GMCm pQgPqvkYYvmz0F1olKVyaA3czaheJTQouA== X-Google-Smtp-Source: ABdhPJzx3x96fJx4faemCDUvxRC/744r0ZvOzwMXOG+Pwr3Ol7rw3HIWe1c3gtl4Bh2a+37lTPe8PQ== X-Received: by 2002:ac8:5e4f:: with SMTP id i15mr5168259qtx.47.1611078287741; Tue, 19 Jan 2021 09:44:47 -0800 (PST) Received: from ?IPv6:2804:7f0:8284:874d:d30:badf:862b:1627? ([2804:7f0:8284:874d:d30:badf:862b:1627]) by smtp.gmail.com with ESMTPSA id u1sm4362624qth.19.2021.01.19.09.44.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jan 2021 09:44:47 -0800 (PST) Subject: Re: [PATCH] trad-frame cleanups To: Simon Marchi , gdb-patches@sourceware.org References: <20210119142014.1949161-1-luis.machado@linaro.org> <059e1efb-fc68-75ce-43ef-76ae4157d93c@polymtl.ca> From: Luis Machado Message-ID: <1cb17f40-80cf-a019-74b4-5cf62a2787af@linaro.org> Date: Tue, 19 Jan 2021 14:44:43 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <059e1efb-fc68-75ce-43ef-76ae4157d93c@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2021 17:44:49 -0000 On 1/19/21 12:22 PM, Simon Marchi wrote: > > > On 2021-01-19 9:20 a.m., Luis Machado via Gdb-patches wrote: >> With the new member functions for struct trad_frame_saved_reg, there is no >> need to invoke some of the set/get functions anymore. This patch removes >> those and adjusts all callers. >> >> Even though the most natural initial state of a saved register value is >> UNKNOWN, there are target backends relying on the previous initial state >> of REALREG set to a register's own number. I noticed this in at least a >> couple targets: aarch64 and riscv. >> >> Because of that, I decided to keep the reset function that sets the set of >> register values to REALREG. I can't exercise all the targets to make sure >> the initial state change won't break things, hence why it is risky to change >> the default. >> >> Validated with --enable-targets=all on aarch64-linux Ubuntu 18.04/20.04. >> >> Thoughts? > > I did a spot check on a few files, and that LGTM, thanks! Thanks. Pushed now.