From: Simon Marchi <simon.marchi@polymtl.ca>
To: Enze Li <lienze2010@hotmail.com>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 18/34] Introduce the new DWARF index class
Date: Thu, 14 Apr 2022 07:52:22 -0400 [thread overview]
Message-ID: <1cd33618-ab24-c571-49c5-18257b03ffd9@polymtl.ca> (raw)
In-Reply-To: <MEAP282MB0293D4E1E97C127B5524893CDDEF9@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM>
On 2022-04-14 01:32, Enze Li via Gdb-patches wrote:
> Hi Tom,
>
> From this commit 51f5a4b8e93("Introduce the new DWARF index class"), I
> ran into this error:
>
> ===================================================================
> CXX dwarf2/cooked-index.o
> In file included from dwarf2/cooked-index.c:21:
> ./dwarf2/cooked-index.h:169:12: error: explicitly defaulted move
> constructor is implicitly deleted [-Werror,-Wdefaulted-function-
> deleted]
> explicit cooked_index (cooked_index &&other) = default;
> ^
> ./dwarf2/cooked-index.h:247:16: note: move constructor of
> 'cooked_index' is implicitly deleted because field 'm_storage' has a
> deleted move constructor
> auto_obstack m_storage;
> ^
> ./../gdbsupport/gdb_obstack.h:128:28: note: 'auto_obstack' has been
> explicitly marked deleted here
> DISABLE_COPY_AND_ASSIGN (auto_obstack);
> ^
> In file included from dwarf2/cooked-index.c:21:
> ./dwarf2/cooked-index.h:171:17: error: explicitly defaulted move
> assignment operator is implicitly deleted [-Werror,-Wdefaulted-
> function-deleted]
> cooked_index &operator= (cooked_index &&other) = default;
> ^
> ./dwarf2/cooked-index.h:247:16: note: move assignment operator of
> 'cooked_index' is implicitly deleted because field 'm_storage' has a
> deleted move assignment operator
> auto_obstack m_storage;
> ^
> ./../gdbsupport/gdb_obstack.h:128:3: note: 'operator=' has been
> explicitly marked deleted here
> DISABLE_COPY_AND_ASSIGN (auto_obstack);
> ^
> ./../include/ansidecl.h:425:8: note: expanded from macro
> 'DISABLE_COPY_AND_ASSIGN'
> void operator= (const TYPE &) = delete
> ^
> 2 errors generated.
> make[2]: *** [Makefile:1892: dwarf2/cooked-index.o] Error 1
> ===================================================================
>
> This happens on Fedora 35 with clang13 and Ubuntu 22.04 with clang14.
>
> Thanks,
> Enze
Here's a proposed patch:
https://sourceware.org/pipermail/gdb-patches/2022-April/187832.html
Simon
next prev parent reply other threads:[~2022-04-14 11:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 19:53 [PATCH v4 00/34] Rewrite the DWARF "partial" reader Tom Tromey
2022-04-04 19:53 ` [PATCH v4 01/34] Allow thread-pool.h to work without threads Tom Tromey
2022-04-08 16:13 ` Pedro Alves
2022-04-04 19:53 ` [PATCH v4 02/34] Split create_addrmap_from_aranges Tom Tromey
2022-04-04 19:53 ` [PATCH v4 03/34] Fix latent bug in read_addrmap_from_aranges Tom Tromey
2022-04-04 19:53 ` [PATCH v4 04/34] Add dwarf2_per_cu_data::addresses_seen Tom Tromey
2022-04-04 19:53 ` [PATCH v4 05/34] Refactor dwarf2_get_pc_bounds Tom Tromey
2022-04-04 19:53 ` [PATCH v4 06/34] Allow ada_decode not to decode operators Tom Tromey
2022-04-04 19:53 ` [PATCH v4 07/34] Let skip_one_die not skip children Tom Tromey
2022-04-04 19:53 ` [PATCH v4 08/34] Add name splitting Tom Tromey
2022-04-04 19:53 ` [PATCH v4 09/34] Add new overload of dwarf5_djb_hash Tom Tromey
2022-04-04 19:53 ` [PATCH v4 10/34] Refactor build_type_psymtabs_reader Tom Tromey
2022-04-04 19:53 ` [PATCH v4 11/34] Add batching parameter to parallel_for_each Tom Tromey
2022-04-04 19:53 ` [PATCH v4 12/34] Return vector of results from parallel_for_each Tom Tromey
2022-04-04 19:53 ` [PATCH v4 13/34] Specialize std::hash for gdb_exception Tom Tromey
2022-04-04 19:53 ` [PATCH v4 14/34] Add "fullname" handling to file_and_directory Tom Tromey
2022-04-04 19:53 ` [PATCH v4 15/34] Introduce DWARF abbrev cache Tom Tromey
2022-04-04 19:53 ` [PATCH v4 16/34] Statically examine abbrev properties Tom Tromey
2022-04-04 19:53 ` [PATCH v4 17/34] Update skip_one_die for new " Tom Tromey
2022-04-04 19:53 ` [PATCH v4 18/34] Introduce the new DWARF index class Tom Tromey
2022-04-10 17:38 ` Tom Tromey
2022-04-14 5:32 ` Enze Li
2022-04-14 11:52 ` Simon Marchi [this message]
2022-04-04 19:53 ` [PATCH v4 19/34] The new DWARF indexer Tom Tromey
2022-04-04 19:53 ` [PATCH v4 20/34] Implement quick_symbol_functions for cooked DWARF index Tom Tromey
2022-04-04 19:53 ` [PATCH v4 21/34] Wire in the new DWARF indexer Tom Tromey
2022-04-04 19:53 ` [PATCH v4 22/34] Introduce thread-safe handling for complaints Tom Tromey
2022-04-04 19:53 ` [PATCH v4 23/34] Pre-read DWARF section data Tom Tromey
2022-04-04 19:53 ` [PATCH v4 24/34] Parallelize DWARF indexing Tom Tromey
2022-04-04 19:53 ` [PATCH v4 25/34] "Finalize" the DWARF index in the background Tom Tromey
2022-04-04 19:53 ` [PATCH v4 26/34] Rename write_psymtabs_to_index Tom Tromey
2022-04-04 19:53 ` [PATCH v4 27/34] Change the key type in psym_index_map Tom Tromey
2022-04-04 19:53 ` [PATCH v4 28/34] Change parameters to write_address_map Tom Tromey
2022-04-04 19:53 ` [PATCH v4 29/34] Genericize addrmap handling in the DWARF index writer Tom Tromey
2022-04-04 19:53 ` [PATCH v4 30/34] Adapt .gdb_index writer to new DWARF scanner Tom Tromey
2022-04-04 19:53 ` [PATCH v4 31/34] Adapt .debug_names " Tom Tromey
2022-04-04 19:53 ` [PATCH v4 32/34] Enable the new DWARF indexer Tom Tromey
2022-04-04 19:53 ` [PATCH v4 33/34] Delete DWARF psymtab code Tom Tromey
2022-04-04 19:53 ` [PATCH v4 34/34] Remove dwarf2_per_cu_data::v Tom Tromey
2022-04-12 15:30 ` [PATCH v4 00/34] Rewrite the DWARF "partial" reader Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cd33618-ab24-c571-49c5-18257b03ffd9@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=lienze2010@hotmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).