From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78107 invoked by alias); 22 Jun 2017 13:45:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76346 invoked by uid 89); 22 Jun 2017 13:45:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1241 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 13:45:14 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD74C7C82E; Thu, 22 Jun 2017 13:45:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DD74C7C82E Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DD74C7C82E Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C591A6061E; Thu, 22 Jun 2017 13:45:10 +0000 (UTC) Subject: Re: [PATCH] Remove an instance of MAX_REGISTER_SIZE from record-full.c To: Alan Hayward References: <69EEE46A-D88C-4B4F-86A2-E35F6DAFD90A@arm.com> <86d1a9a2k9.fsf@gmail.com> Cc: Yao Qi , "gdb-patches@sourceware.org" , nd From: Pedro Alves Message-ID: <1d20094c-9d73-bb9e-2bda-858dbc8f59bd@redhat.com> Date: Thu, 22 Jun 2017 13:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00647.txt.bz2 On 06/22/2017 02:44 PM, Alan Hayward wrote: > >> On 21 Jun 2017, at 11:52, Pedro Alves wrote: >> >> On 06/12/2017 02:59 PM, Alan Hayward wrote: >> >>> diff --git a/gdb/record-full.c b/gdb/record-full.c >>> index 31ff558d2a633cff71d3e6082e42f5d6fb88bcf1..4f73e2a5ad0d4a2407b31a1d391e813147e15798 100644 >>> --- a/gdb/record-full.c >>> +++ b/gdb/record-full.c >>> @@ -698,7 +698,7 @@ record_full_exec_insn (struct regcache *regcache, >>> { >>> case record_full_reg: /* reg */ >>> { >>> - gdb_byte reg[MAX_REGISTER_SIZE]; >>> + gdb_byte *reg = (gdb_byte *) xmalloc (entry->u.reg.len); >>> >>> if (record_debug > 1) >>> fprintf_unfiltered (gdb_stdlog, >>> @@ -711,6 +711,7 @@ record_full_exec_insn (struct regcache *regcache, >>> regcache_cooked_write (regcache, entry->u.reg.num, >>> record_full_get_loc (entry)); >>> memcpy (record_full_get_loc (entry), reg, entry->u.reg.len); >>> + xfree (reg); >> >> You can use >> gdb::byte_vector reg (entry->u.reg.len); >> to avoid the explicit xfree here. >> >> (and a potential leak if regcache_* throws). >> >> Thanks, >> Pedro Alves >> > > Updated and retested. > > Ok to commit? Sure. Thanks, Pedro Alves