From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A4ADB385842D for ; Fri, 2 Dec 2022 14:44:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4ADB385842D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 276DC1E112; Fri, 2 Dec 2022 09:44:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1669992244; bh=ixHigPtcz0TkwrtCVdEhmRsZTDCstW/dCAI+I7OrJmE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=ar5bZWSiFcbZOKqPzmeJFTkULSsoJBBAs4ZBDaumozTM5nu1ACpIM+2TuRm+/Xrxl Sw59CgbP6sWs23X84A0F/IfoGpl1cS2YLbgq0Su6COk9Rw385tC9bo9Ul2uLRGHykq 0lmffP19/QMkmp1mzV2lZgaJ6SLkfo3O1LxjI8lM= Message-ID: <1d36d282-2e72-c42d-777f-7034091ec991@simark.ca> Date: Fri, 2 Dec 2022 09:44:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 0/2] Fix tab vs spaces in generated gdbarch.c Content-Language: en-US To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20221201223914.366184-1-thiago.bauermann@linaro.org> From: Simon Marchi In-Reply-To: <20221201223914.366184-1-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/1/22 17:39, Thiago Jung Bauermann via Gdb-patches wrote: > Hello, > > If you change gdbarch-components.py and submit a patch containing the > generated gdbarch.c file, git will point out that it contains whitespace > errors, e.g.: > > Applying: gdb/aarch64: Detect vector length changes when debugging remotely > .git/rebase-apply/patch:164: indent with spaces. > "gdbarch_dump: update_architecture = <%s>\n", > .git/rebase-apply/patch:165: indent with spaces. > host_address_to_string (gdbarch->update_architecture)); > .git/rebase-apply/patch:186: indent with spaces. > gdbarch_update_architecture_ftype update_architecture) > warning: 3 lines add whitespace errors. Oh, and it's because Andrew added this to .gitattributes: https://gitlab.com/gnutools/binutils-gdb/-/commit/f7f904e4fda6fb571d40a3547ed03ec6028e6694 I didn't remember that. Simon