From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8675D3858CDA for ; Tue, 10 Jan 2023 16:24:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8675D3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id DE8AA1E110; Tue, 10 Jan 2023 11:24:35 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1673367876; bh=8akmB3RVhLdFoyzPZ4vSaVTGqVx1YzJsRs/DHUkDhJI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Kfst72PXi091Tc6m4P5RYPyyD/hf30awIRAoTNnhdajU3EwIc55dD2dLvutBlbP10 rRfaatu6My6uehh8T86yGXZCIgQu/C4gh5bT5vNgEz6O3+SgU53tsOSI/JuziauReI dZP/HrCB+YgsD/giK8x20NTqjCFBKhaXVK3ywRxc= Message-ID: <1d47b647-b6d5-4a75-36e8-b2dd1b2d7266@simark.ca> Date: Tue, 10 Jan 2023 11:24:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] Convert say_where to method on code_breakpoint Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230110151821.2302229-1-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20230110151821.2302229-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/10/23 10:18, Tom Tromey via Gdb-patches wrote: > 'say_where' is only useful (and only called for) code breakpoints, so > convert it to be a protected method on code_breakpoint. LGTM, thanks. Simon