From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41713 invoked by alias); 14 Feb 2017 03:36:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41688 invoked by uid 89); 14 Feb 2017 03:36:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.3 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=stbcx, stdcx, lbarx, ldarx X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Feb 2017 03:36:08 +0000 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v1E3TV6v036288 for ; Mon, 13 Feb 2017 22:36:07 -0500 Received: from e24smtp01.br.ibm.com (e24smtp01.br.ibm.com [32.104.18.85]) by mx0a-001b2d01.pphosted.com with ESMTP id 28kfdtgpgh-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 13 Feb 2017 22:36:07 -0500 Received: from localhost by e24smtp01.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Feb 2017 01:36:04 -0200 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp01.br.ibm.com (10.172.0.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 14 Feb 2017 01:35:59 -0200 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 905843520068 for ; Mon, 13 Feb 2017 22:35:25 -0500 (EST) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.8.31.91]) by d24relay01.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v1E3ZwMn5193738 for ; Tue, 14 Feb 2017 01:35:58 -0200 Received: from d24av01.br.ibm.com (localhost [127.0.0.1]) by d24av01.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v1E3Zw3P002858 for ; Tue, 14 Feb 2017 01:35:58 -0200 Received: from [9.85.148.239] ([9.85.148.239]) by d24av01.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id v1E3ZtvV002850; Tue, 14 Feb 2017 01:35:57 -0200 Subject: [PATCH] [trivial] Fix test names starting with uppercase in gdb.arch/ppc64-atomic-inst.exp To: Luis Machado , gdb-patches@sourceware.org References: <1486350182-13993-1-git-send-email-emachado@linux.vnet.ibm.com> <38fe05a1-770c-e9f1-ecc0-042dfe0a470e@codesourcery.com> Cc: uweigand@de.ibm.com From: Edjunior Barbosa Machado Date: Tue, 14 Feb 2017 03:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <38fe05a1-770c-e9f1-ecc0-042dfe0a470e@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17021403-1523-0000-0000-0000027F52EB X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17021403-1524-0000-0000-00002A145357 Message-Id: <1d9ca4d1-7101-e16d-4f78-93991f3d4d15@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-14_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702140036 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00369.txt.bz2 On 02/06/2017 08:03 AM, Luis Machado wrote: >> @@ -52,6 +54,18 @@ proc do_test { displaced } { >> gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \ >> "Set the breakpoint at the start of the ldarx/stdcx sequence" >> >> + set bp3 [gdb_get_line_number "lbarx"] >> + gdb_breakpoint "$bp3" "Breakpoint $decimal at $hex" \ >> + "Set the breakpoint at the start of the lbarx/stbcx sequence" > > I think my previous set of testsuite fixups failed to catch these test > names starting with uppercase. But we're requiring test names to start > with lowercase now. I can address the rest of the offenders in a future > patch, but new code should have the right format. > Hi, this trivial patch fixes the test names starting with uppercase using gdb_test in gdb.arch/ppc64-atomic-inst.exp. Thanks, -- Edjunior gdb/testsuite/ 2017-02-14 Edjunior Barbosa Machado * gdb.arch/ppc64-atomic-inst.exp: Fix test names starting with uppercase. --- gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp index d1b3a7d..7bfff6c 100644 --- a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp +++ b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp @@ -46,23 +46,23 @@ proc do_test { displaced } { set bp1 [gdb_get_line_number "lwarx"] gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \ - "Set the breakpoint at the start of the lwarx/stwcx sequence" + "set the breakpoint at the start of the lwarx/stwcx sequence" set bp2 [gdb_get_line_number "ldarx"] gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \ - "Set the breakpoint at the start of the ldarx/stdcx sequence" + "set the breakpoint at the start of the ldarx/stdcx sequence" gdb_test continue "Continuing.*Breakpoint $decimal.*" \ - "Continue until lwarx/stwcx start breakpoint" + "continue until lwarx/stwcx start breakpoint" gdb_test nexti "bne.*1b" \ - "Step through the lwarx/stwcx sequence" + "step through the lwarx/stwcx sequence" gdb_test continue "Continuing.*Breakpoint $decimal.*" \ - "Continue until ldarx/stdcx start breakpoint" + "continue until ldarx/stdcx start breakpoint" gdb_test nexti "bne.*1b" \ - "Step through the ldarx/stdcx sequence" + "step through the ldarx/stdcx sequence" } foreach displaced { "off" "on" } { -- 1.8.3.1