From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va-2-39.ptr.blmpb.com (va-2-39.ptr.blmpb.com [209.127.231.39]) by sourceware.org (Postfix) with UTF8SMTPS id 71CFE3858CD1 for ; Wed, 15 Nov 2023 02:20:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 71CFE3858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oss.cipunited.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 71CFE3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.127.231.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700014813; cv=none; b=pZ0y+4nUlCfmco98zFwStLMeTuH/SG+77TIUlSzZIkJ1SQhiVRR/7/CGX22YfNhvebZ7u642Y/KiVFGC4n3duSyUFTGxXMLIqZyJ4cBbbrwh7tJRKYrkrW2OBp4pBCmsmzYY2KTEMG6MkNeQFT1TFTi3AAbAdD1Ef/xXwXOmqKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700014813; c=relaxed/simple; bh=pEzc9+aJ14d2iDMgnVNJI0+gHNw03vqzoT67m4g0f58=; h=DKIM-Signature:Subject:To:Mime-Version:From:Date:Message-Id; b=yB2EUxOMZdooSnmMs6XB9pg7Nk5eHk0zuKlJXSZomNx5bhKL7WTL6E35tb3VYGk90zFGxXP5ChWOanWl3OdekYkM52G9s8LiRc3KFRMXHRlkFnbaswQs/hoEhMx8RSHwNsJrCzF1VESe9dXD2leF6fEtn9vst/ZP3c0YYdPICTU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2303200042; d=oss.cipunited.com; t=1700014801; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=/liwIcf/VZ6Ru1sboKC4Wo4iRBm7d9DBaCc1fC+sH50=; b=aKuQeCu5JGfaPdM+2izMUZB1Hj58UX+djTdKDeXusW+pLCm6JKTbq3H20ecgoLsvhrgOC+ cv7X4NuWy+rvTluayfp9AbdloPINYxsrV2Yoh9dY56E/hxilObUykW8wqUMQX5NforjMjV cyhu7zzgJPXMe6N5gc2C5tw6zjXUGi3rcBQjcLBQy/Md9GFNCAvTvcQVAjdPqEZoi+T90T uLGryaaUCZq8uJ01yZeGxWL6LB47ErQwY53IWmrDk2xorI59rXuPyN10+wUjjlFQbi5p4T mSmKb3MdrQWkFVv9gzlthRBv7e/Le7MAsjcQDCNU5VO8WQhUeq7WrieU2s0X/g== Cc: Subject: Re: [PATCH 0/2] Change all E_MIPS_* to EF_MIPS_* Content-Type: text/plain; charset=UTF-8 Content-Language: en-US References: <20231114094535.434194-1-ying.huang@oss.cipunited.com> <5c52259b-f9af-4227-bc2e-addda3f50cf6@palves.net> In-Reply-To: <5c52259b-f9af-4227-bc2e-addda3f50cf6@palves.net> Received: from [192.168.8.150] ([1.192.16.206]) by smtp.feishu.cn with ESMTPS; Wed, 15 Nov 2023 10:19:59 +0800 To: "Pedro Alves" , Mime-Version: 1.0 X-Lms-Return-Path: User-Agent: Mozilla Thunderbird From: "Ying Huang" Date: Wed, 15 Nov 2023 10:19:57 +0800 Message-Id: <1dafc95f-33c3-4d81-8d57-ef3d4cc14031@oss.cipunited.com> X-Original-From: Ying Huang Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Pedro, =E5=9C=A8 2023/11/14 19:43, Pedro Alves =E5=86=99=E9=81=93: > On 2023-11-14 09:45, Ying Huang wrote: >> According to we have changed all E_MIPS_* to EF_MIPS_* in binutils >> and glibc, we also need to change it here to keep same style. >> We can refer to this commit record: >> https://sourceware.org/pipermail/binutils/2023-October/129904.html > This is OK, but please put this information in the commit logs themselves= , so that > if someone in the future needs to "git blame" the touched lines isn't lef= t with > an empty rationale for the change. > > So, you can add my: > > Approved-By: Pedro Alves > > with that change. > OK, I would send patch V2 with commit message. Thanks, Ying