From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH][gdb/exp] Fix internal error when printing C++ pointer-to-member
Date: Tue, 5 Jul 2022 22:42:06 +0200 [thread overview]
Message-ID: <1dce1ba8-6f29-1ddc-ca83-720722a7c3ca@suse.de> (raw)
In-Reply-To: <87fsjfv1l4.fsf@tromey.com>
On 7/5/22 20:47, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> (gdb) print ptm^M
> Tom> $1 = gdb/gdbtypes.h:695: internal-error: loc_bitpos: \
> Tom> Assertion `m_loc_kind == FIELD_LOC_KIND_BITPOS' failed.^M
> Tom> ...
> Tom> while printing a c++ pointer-to-member.
>
> Is this crashing due to the static field?
>
Yes.
> Tom> Fix this by skipping fields with m_loc_kind != FIELD_LOC_KIND_BITPOS in
> Tom> cp_find_class_member, such that we have:
> Tom> ...
> Tom> (gdb) print ptm^M
> Tom> $1 = &A::i^M
> Tom> ...
>
> If so then I think it's better to skip when the field is static, not
> based on the loc_kind.
Ack, committed using field_is_static instead.
Thanks,
- Tom
prev parent reply other threads:[~2022-07-05 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 14:59 Tom de Vries
2022-07-05 18:47 ` Tom Tromey
2022-07-05 20:42 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dce1ba8-6f29-1ddc-ca83-720722a7c3ca@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).