From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb, gdbserver: remove WinCE support code
Date: Mon, 12 Apr 2021 11:12:13 -0400 [thread overview]
Message-ID: <1dd71397-369c-b88f-832d-b6c525e5bee8@polymtl.ca> (raw)
In-Reply-To: <563cec09-990a-77f4-042f-2b95215e9829@palves.net>
On 2021-04-12 7:42 a.m., Pedro Alves wrote:
> On 11/04/21 00:10, Simon Marchi via Gdb-patches wrote:
>> The support for WinCE was removed with commit 84b300de3666 ("gdbserver:
>> remove support for ARM/WinCE"). There is some leftover code for WinCE
>> support, guarded by the _WIN32_WCE macro, which I didn't know of at the
>> time.
>>
>> I didn't remove the _WIN32_WCE references in the tests, because in
>> theory we still support the WinCE architecture in GDB (when debugging
>> remotely). So someone could run a test with that (although I'd be
>> really surprised).
>>
>> gdb/ChangeLog:
>>
>> * nat/windows-nat.c: Remove all code guarded by _WIN32_WCE.
>> * nat/windows-nat.h: Likewise.
>>
>> gdbserver/ChangeLog:
>>
>> * win32-low.cc: Remove all code guarded by _WIN32_WCE.
>> * win32-low.h: Likewise.
>
> OK.
>
> We can also get rid of the whole
>
> the_target->hostio_last_error / hostio-errno.cc / hostio_last_error_from_errno
>
> abstraction now.
Ok, I didn't really know what that was for. I pushed the patch and will
send a follow up for that.
Simon
next prev parent reply other threads:[~2021-04-12 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 23:10 Simon Marchi
2021-04-12 11:42 ` Pedro Alves
2021-04-12 15:12 ` Simon Marchi [this message]
2021-04-12 15:24 ` Simon Marchi
2021-04-12 22:20 ` [PATCH] Remove process_stratum_target::hostio_last_error abstraction (Re: [PATCH] gdb, gdbserver: remove WinCE support code) Pedro Alves
2021-04-12 22:52 ` Pedro Alves
2021-04-12 23:56 ` Simon Marchi
2021-04-13 13:12 ` Pedro Alves
2021-04-12 13:57 ` [PATCH] gdb, gdbserver: remove WinCE support code Luis Machado
2021-04-12 14:01 ` Simon Marchi
2021-04-12 14:07 ` Luis Machado
2021-04-13 19:29 ` Tom Tromey
2021-04-13 21:14 ` Pedro Alves
2021-04-13 21:20 ` [pushed] Remove WinCE code from gdbreplay Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dd71397-369c-b88f-832d-b6c525e5bee8@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).