From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id A1CA0385BF99 for ; Mon, 12 Apr 2021 15:12:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A1CA0385BF99 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13CFCDat024251 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Apr 2021 11:12:18 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13CFCDat024251 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8BC111E789; Mon, 12 Apr 2021 11:12:13 -0400 (EDT) Subject: Re: [PATCH] gdb, gdbserver: remove WinCE support code To: Pedro Alves , gdb-patches@sourceware.org References: <20210410231021.1232451-1-simon.marchi@polymtl.ca> <563cec09-990a-77f4-042f-2b95215e9829@palves.net> From: Simon Marchi Message-ID: <1dd71397-369c-b88f-832d-b6c525e5bee8@polymtl.ca> Date: Mon, 12 Apr 2021 11:12:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <563cec09-990a-77f4-042f-2b95215e9829@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 12 Apr 2021 15:12:13 +0000 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2021 15:12:25 -0000 On 2021-04-12 7:42 a.m., Pedro Alves wrote: > On 11/04/21 00:10, Simon Marchi via Gdb-patches wrote: >> The support for WinCE was removed with commit 84b300de3666 ("gdbserver: >> remove support for ARM/WinCE"). There is some leftover code for WinCE >> support, guarded by the _WIN32_WCE macro, which I didn't know of at the >> time. >> >> I didn't remove the _WIN32_WCE references in the tests, because in >> theory we still support the WinCE architecture in GDB (when debugging >> remotely). So someone could run a test with that (although I'd be >> really surprised). >> >> gdb/ChangeLog: >> >> * nat/windows-nat.c: Remove all code guarded by _WIN32_WCE. >> * nat/windows-nat.h: Likewise. >> >> gdbserver/ChangeLog: >> >> * win32-low.cc: Remove all code guarded by _WIN32_WCE. >> * win32-low.h: Likewise. > > OK. > > We can also get rid of the whole > > the_target->hostio_last_error / hostio-errno.cc / hostio_last_error_from_errno > > abstraction now. Ok, I didn't really know what that was for. I pushed the patch and will send a follow up for that. Simon