From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Defer breakpoint reset when cloning progspace for fork child
Date: Mon, 09 Apr 2018 19:35:00 -0000 [thread overview]
Message-ID: <1df7e229d358d1f993ad725096e6f69f@polymtl.ca> (raw)
In-Reply-To: <d7396db0-8e0a-da87-5f14-96a4fa78a9ac@redhat.com>
On 2018-04-09 15:21, Pedro Alves wrote:
> While a board file as a new test more may be useful, I think there's
> value in having smoke tests that run with the default board too. Just
> like we have other tests in the tree that exercise basic PIE, gdb
> index,
> fission, etc. already. E.g., we test PIE+exec in
> gdb.base/pie-execl.exp.
>
> I was not saying to update the existing fork tests, but instead to
> add the small test that you described in the commit log as a testcase.
>
> Let me put it another way -- I suspect that if you had discovered
> this issue on a system with a compiler that does _not_ emit PIE
> by default, you'd have likely considered adding a small test.
Ok, I agree.
Simon
prev parent reply other threads:[~2018-04-09 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 19:01 Simon Marchi
2018-04-07 17:52 ` Simon Marchi
2018-04-07 18:43 ` Pedro Alves
2018-04-09 19:10 ` Simon Marchi
2018-04-09 19:21 ` Pedro Alves
2018-04-09 19:35 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1df7e229d358d1f993ad725096e6f69f@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).