From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id A63E83959E4B for ; Sun, 18 Sep 2022 05:45:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A63E83959E4B Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CC7EF1FBAF; Sun, 18 Sep 2022 05:45:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AC4B513A49; Sun, 18 Sep 2022 05:45:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CPKAKGawJmMMBgAAMHmgww (envelope-from ); Sun, 18 Sep 2022 05:45:10 +0000 Message-ID: <1e04fad6-5160-3897-9b83-15067ed59313@suse.de> Date: Sun, 18 Sep 2022 07:45:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] gdb: add ATTRIBUTE_PRINTF to gdb_bfd_error_handler Content-Language: en-US To: Enze Li , gdb-patches@sourceware.org Cc: enze.li@gmx.com References: From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Sep 2022 05:45:13 -0000 On 9/18/22 06:58, Enze Li via Gdb-patches wrote: > I see this error when building with clang, > > CXX gdb_bfd.o > gdb_bfd.c:1180:43: error: format string is not a string literal [-Werror,-Wformat-nonliteral] > const std::string str = string_vprintf (fmt, ap_copy); > ^~~ > 1 error generated. > > This patch adds missing ATTRIBUTE_PRINTF to fix the error. > > Tested on x86_64-linux with gcc 12 and clang 14. LGTM. Thanks, - Tom > --- > gdb/gdb_bfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c > index 6299148d419..c5a5ed95e8e 100644 > --- a/gdb/gdb_bfd.c > +++ b/gdb/gdb_bfd.c > @@ -1170,7 +1170,7 @@ static bfd_error_handler_type default_bfd_error_handler; > messages which have been printed once already. This is done on a > per-inferior basis. */ > > -static void > +static void ATTRIBUTE_PRINTF (1, 0) > gdb_bfd_error_handler (const char *fmt, va_list ap) > { > va_list ap_copy;