From: Simon Marchi <simon.marchi@ericsson.com>
To: Richard Bunt <richard.bunt@arm.com>, <gdb-patches@sourceware.org>
Cc: <nd@arm.com>
Subject: Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach
Date: Wed, 27 Jun 2018 13:31:00 -0000 [thread overview]
Message-ID: <1e078ab0-4965-88fc-c711-2db9e99f1364@ericsson.com> (raw)
In-Reply-To: <d8b751d8-b6dd-2bda-50cd-102e0d9fe32a@arm.com>
On 2018-06-27 06:17 AM, Richard Bunt wrote:
> Fixed top frame assumption in watchpoint-hw-attach
>
> watchpoint-hw-attach.exp was noticed to fail on some machines.
> Thanks to the input from sergiodj and palves on the IRC channel,
> it was concluded that the test case incorrectly assumed that on
> attach it was landed in the top-most frame of the inferior. This
> was fixed by running to a break point in main by explicitly
> defining the source file name before continuing with the test.
>
> Tested on the following architectures x86_64, aarch64 and ppc64le.
LGTM, thanks!
Simon
next prev parent reply other threads:[~2018-06-27 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 10:18 Richard Bunt
2018-06-27 13:31 ` Simon Marchi [this message]
2018-06-29 14:51 ` Pedro Alves
2018-06-29 15:23 ` Richard Bunt
2018-06-29 16:39 ` Richard Bunt
2018-06-29 16:40 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e078ab0-4965-88fc-c711-2db9e99f1364@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=richard.bunt@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).