From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109159 invoked by alias); 27 Jun 2018 13:31:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108678 invoked by uid 89); 27 Jun 2018 13:30:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 13:30:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1530106213; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9OA4q0FdDDEtHe4LAF1qFavTQFcLI+xtaHaYFMlgHxU=; b=Y0dB98EzelCJ3k/2NVMAz6LqvW6x4BERC/i/t3T77Zg1h1ucdd2uKNSSNxe+QjVr WKF1jVjUnus3HNfyLgsvi3mqEe7HMfJRwythJ3PQvnxdAFNSR9tFAPl8BV+6kShF zQ90de/NdzmNBxEYf2pSbp0KCHwFG+lxNLi6nm1xZT0=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 5D.0C.31551.561933B5; Wed, 27 Jun 2018 15:30:13 +0200 (CEST) Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 27 Jun 2018 15:29:30 +0200 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 27 Jun 2018 15:29:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fTqzBhdndax+714hfRIe1XnnoI7mtVv19TG1+GQgsDk=; b=ORjICAY5MEf0FV0EFdYL8xNWFM0Y4oLoAjy7FkIsjyTmX+caVpdGcLaFhNBy78K/1GSIXI5lYrmse4WA8YAQomizY0tW5q5KElTZrO/CQwRxMrT0tYeFSbP5Nx2g5t2qFCqxFz+fJQlOJ702QF8Rk9Cty4sV/abOEDvMayUiB04= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [100.94.229.156] (129.192.64.65) by BYAPR15MB2390.namprd15.prod.outlook.com (2603:10b6:a02:8c::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.24; Wed, 27 Jun 2018 13:29:27 +0000 Subject: Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach To: Richard Bunt , CC: References: From: Simon Marchi Message-ID: <1e078ab0-4965-88fc-c711-2db9e99f1364@ericsson.com> Date: Wed, 27 Jun 2018 13:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00646.txt.bz2 On 2018-06-27 06:17 AM, Richard Bunt wrote: > Fixed top frame assumption in watchpoint-hw-attach > > watchpoint-hw-attach.exp was noticed to fail on some machines. > Thanks to the input from sergiodj and palves on the IRC channel, > it was concluded that the test case incorrectly assumed that on > attach it was landed in the top-most frame of the inferior. This > was fixed by running to a break point in main by explicitly > defining the source file name before continuing with the test. > > Tested on the following architectures x86_64, aarch64 and ppc64le. LGTM, thanks! Simon