From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 272C93873CC0 for ; Fri, 16 Dec 2022 13:33:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 272C93873CC0 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2BGDWt7S008213 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Dec 2022 08:33:00 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2BGDWt7S008213 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1671197580; bh=tw+cRlP/pLIlp4YhJA1uQGzj9V1cXeqqsbSBB61D5y4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=HB/3pZfZXiMY15a/fH2mHh2KDnNup8tEFVnEsOnkmPmBYw5mBzUzQ2kr7SzAIX+Gc DurkPnCyLkBEi1v9gMpi8NkhX1JGqm+Vz0dIvUMKZkmheGWtsEfVfBapa9/YpHtxhP Vqx1ACKauHXy9Zp2+SBmxfiVAgXLhWXZcNv7eGys= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 553E11E112; Fri, 16 Dec 2022 08:32:55 -0500 (EST) Message-ID: <1e3043f0-c2e0-ebf0-5679-dddd04e6bd85@polymtl.ca> Date: Fri, 16 Dec 2022 08:32:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 0/2] Remove one use of struct buffer Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20221216060148.1261366-1-simon.marchi@polymtl.ca> <89bc07a5-59a4-272f-f30e-0fd5e3fe3ccd@palves.net> From: Simon Marchi In-Reply-To: <89bc07a5-59a4-272f-f30e-0fd5e3fe3ccd@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 16 Dec 2022 13:32:55 +0000 X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/16/22 08:09, Pedro Alves wrote: > On 2022-12-16 6:01 a.m., Simon Marchi via Gdb-patches wrote: >> Tom mentioned the goal of getting rid of struct buffer, and that made me >> remember I had these patches laying around. >> > > Yeah, IIRC, struct buffer existed avoid obstack in gdbserver I think because > back then gdbserver didn't link with libiberty. There used to be a obstack_xml_printf > function too, which was eliminated too since. Glad to see it all go. > >> Simon Marchi (2): >> gdbsupport: add string_xml_appendf >> gdb: convert linux-osdata.c from buffer to std::string > > LGTM. > > ("There is not change" -> "There is no change" in patch 2's commit log.) Fixed and pushed, thanks. Simon