From: John Baldwin <jhb@FreeBSD.org>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] nat/amd64-linux-siginfo.c: Move align attribute from typedef to struct
Date: Mon, 7 Jun 2021 15:42:59 -0700 [thread overview]
Message-ID: <1eed47ed-3f03-8b27-e740-da1e56528af3@FreeBSD.org> (raw)
In-Reply-To: <00f901fb-b420-35e4-262f-65e4e3bacb3d@palves.net>
On 6/7/21 3:20 PM, Pedro Alves wrote:
> See answer 4 here:
>
> https://stackoverflow.com/questions/15788947/where-can-i-use-alignas-in-c11
>
> "These are the only places where the standard says an alignment-specifier (alignas(...)) may be applied.
> Note that this does not include typedef declarations nor alias-declarations."
>
> So for consistency I'm leaving the struct attribute as is too.
>
> I'm going to merge the patches now.
Ah, I agree that it's good to be consistent.
--
John Baldwin
next prev parent reply other threads:[~2021-06-07 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 0:14 [PATCH 0/2] Fix alignment issue flagged by Clang in nat/amd64-linux-siginfo.c Pedro Alves
2021-06-05 0:14 ` [PATCH 1/2] nat/amd64-linux-siginfo.c: Move align attribute from typedef to struct Pedro Alves
2021-06-05 21:20 ` John Baldwin
2021-06-07 22:20 ` Pedro Alves
2021-06-07 22:42 ` John Baldwin [this message]
2021-06-05 0:14 ` [PATCH 2/2] nat/amd64-linux-siginfo.c: Remove typedefs Pedro Alves
2021-06-06 14:41 ` [PATCH 0/2] Fix alignment issue flagged by Clang in nat/amd64-linux-siginfo.c Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eed47ed-3f03-8b27-e740-da1e56528af3@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).