From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 9188D385703F for ; Mon, 7 Jun 2021 22:43:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9188D385703F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 01C7E9D4D4; Mon, 7 Jun 2021 22:43:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FzT0l6Gbzz4jl1; Mon, 7 Jun 2021 22:43:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 73F5C158F; Mon, 7 Jun 2021 22:43:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH 1/2] nat/amd64-linux-siginfo.c: Move align attribute from typedef to struct To: Pedro Alves , gdb-patches@sourceware.org References: <20210605001427.3597687-1-pedro@palves.net> <20210605001427.3597687-2-pedro@palves.net> <31bde046-a86f-9995-545d-a03737cf493b@FreeBSD.org> <00f901fb-b420-35e4-262f-65e4e3bacb3d@palves.net> From: John Baldwin Message-ID: <1eed47ed-3f03-8b27-e740-da1e56528af3@FreeBSD.org> Date: Mon, 7 Jun 2021 15:42:59 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <00f901fb-b420-35e4-262f-65e4e3bacb3d@palves.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 22:43:16 -0000 On 6/7/21 3:20 PM, Pedro Alves wrote: > See answer 4 here: > > https://stackoverflow.com/questions/15788947/where-can-i-use-alignas-in-c11 > > "These are the only places where the standard says an alignment-specifier (alignas(...)) may be applied. > Note that this does not include typedef declarations nor alias-declarations." > > So for consistency I'm leaving the struct attribute as is too. > > I'm going to merge the patches now. Ah, I agree that it's good to be consistent. -- John Baldwin