Re: [PATCH v2 2/3] gdb: Rename fputs_unfiltered to ui_file_puts.

[Simon Marchi <simark@simark.ca>]

On 2019-12-01 10:12 a.m., Simon Marchi wrote:
> On 2019-11-28 7:03 p.m., Iain Buclaw wrote:
>> This patch redefines fputs_unfiltered in utils.c, with new behavior to forward parameters to fputs_maybe_filtered.  This makes fputs_unfiltered identical to fputs_filtered, except filtering is disabled.
>>
>> Some callers of fputs_unfiltered have been updated to use ui_file_puts where they were using other ui_file_* functions anyway for IO.
>>
>> This fixes the problem I saw with \032\032post-prompt annotation being flushed to stdout in the wrong order.
>>
>> --
>> Iain
>>
>> ---
>> gdb/ChangeLog:
>>
>> 2019-11-29  Iain Buclaw  <ibuclaw@gdcproject.org>
>>
>>         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
>>         * gdb/remote.c (remote_console_output): Update.
>>         * gdb/ui-file.c (fputs_unfiltered): Rename to...
>>         (ui_file_puts): ...this.
>>         * gdb/ui-file.h (ui_file_puts): Add declaration.
>>         * gdb/utils.c (emit_style_escape): Update.
>>         (flush_wrap_buffer): Update.
>>         (fputs_maybe_filtered): Update.
>>         (fputs_unfiltered): Add function.
>>
>> ---
>>
>>
> 
> Hi Iain,
> 
> The patch does not apply for me on current master:
> 
> $ git apply ~/patches/uifileputs.patch
> error: patch failed: gdb/remote.c:6782
> error: gdb/remote.c: patch does not apply
> 
> How did you generate this patch?  Could you please send your patches using git-send-email?
> 
> Simon

My bad, I had not seen that this was part of a series (the email is not threaded with the others
of the series).  After applying 1/3, this one applies fine.

Simon