From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 00/15] More TUI Refactorings
Date: Mon, 26 Aug 2019 14:08:00 -0000 [thread overview]
Message-ID: <1efcbd41-aca3-ebea-87f6-9f65a316e91e@redhat.com> (raw)
In-Reply-To: <20190821022535.9762-1-tom@tromey.com>
On 8/21/19 3:25 AM, Tom Tromey wrote:
> Here is another series of TUI refactorings. There should be no
> user-visible changes in this series (patch #1 changes a message, but I
> don't believe it can actually be seen).
>
> I tested each one using the gdb.tui tests. This worked here, though
> as we learned recently, at least empty.exp is not very reliable.
>
> There's about one more series of this size waiting to be submitted,
> plus one (or maybe two) patches that change the TUI in small
> user-visible ways.
LGTM.
Nice to see the number of rerender/refresh methods down.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-08-26 14:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 2:27 Tom Tromey
2019-08-21 2:25 ` [PATCH 03/15] Remove some checks of .empty() Tom Tromey
2019-08-21 2:25 ` [PATCH 09/15] Don't call tui_refresh_all from show_layout Tom Tromey
2019-08-21 2:25 ` [PATCH 10/15] Turn two locator functions into methods Tom Tromey
2019-08-21 2:25 ` [PATCH 07/15] Remove NULL checks from box_win Tom Tromey
2019-08-21 2:25 ` [PATCH 05/15] Private data members in tui_data_window Tom Tromey
2019-08-26 14:06 ` Pedro Alves
2019-08-30 19:06 ` Tom Tromey
2019-08-21 2:25 ` [PATCH 06/15] Simplify register display Tom Tromey
2019-08-21 2:25 ` [PATCH 01/15] Remove NO_DATA_STRING Tom Tromey
2019-08-21 2:25 ` [PATCH 04/15] Remove some calls in tui_data_window Tom Tromey
2019-08-21 2:25 ` [PATCH 12/15] Make tui_locator_window::set_locator_fullname re-render Tom Tromey
2019-08-21 2:25 ` [PATCH 02/15] Remove tui_data_window::display_all_data Tom Tromey
2019-08-21 2:25 ` [PATCH 15/15] Remove tui_win_info::refresh_all Tom Tromey
2019-08-21 2:27 ` [PATCH 11/15] Swap tui_show_locator_content and tui_locator_window::rerender Tom Tromey
2019-08-21 2:27 ` [PATCH 08/15] Don't call touchwin in tui_gen_win_info::refresh_window Tom Tromey
2019-08-21 2:27 ` [PATCH 13/15] Minor rearrangement of tui-stack.c Tom Tromey
2019-08-21 2:31 ` [PATCH 14/15] Don't call wrefresh from tui_cont_sig Tom Tromey
2019-08-26 14:08 ` Pedro Alves [this message]
2019-08-30 19:06 ` [PATCH 00/15] More TUI Refactorings Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1efcbd41-aca3-ebea-87f6-9f65a316e91e@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).