From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2055.outbound.protection.outlook.com [40.107.92.55]) by sourceware.org (Postfix) with ESMTPS id 507773858413 for ; Fri, 4 Nov 2022 16:13:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 507773858413 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GcSvmSqvnf1KMJi6gPti4BDsypR60P9F8Kasvjt/5q2u6aO/AYDTFv2ZwHEOfVrT8LJ336xRVpD3M/bhDGeuHQUdJA1EiQXctMBiYwUGME5HV8jQEjD/aED9X9az8g4LVfFWuL90fWxtagOILFBkpCyYwWORSHS+v+HmIzkKw6Wqa821PvNgVfWVLpjakBVQB37PtglGQEiLAcpwpqZ886/O/Ytyi2x7GBz+4a3/XFL2JAexQvvi051RUFPH1KB3imVgAvo7k7FZMveOxDq8YYL7YiM3Qz1lIfGynGG1zqXRNgTEJVi+677kMCc+mxigLd17IUBaoq3moO/rvYbiKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TPobZON080FHYw5kyiEqWz/rsS6wF88QiIsXWKNATms=; b=KFrmhFMfWDsv09GL5eKrkrhSd6XVGImw1CXmdIIumCahet7VKxk7Cf48f6PGe0XVsKkoBG1onks14nfsJPK/gLWh6dNqQwlP7kWg3Bq5pJFZacbT9HabCmP5lwJiysQc3a5MgkDA8AiADwFnjaPd+7K+cCxlDvOx4Bb4rZNFEp+c+d78bcONgVJNrFBv3B59HvyuDkflx03Gl0V159jCUHxrRsx6UcTotFHr48j4nIqDPXDCtxRQS4GPho/9zxzU9UTZ9vIEqCBmtV88K46uw9kQtn3jlo4n7PdCAAiBOssBQG6ztWHupFWOtwTDnX5nmEWy4WcqcX7AJqBJQqRPPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TPobZON080FHYw5kyiEqWz/rsS6wF88QiIsXWKNATms=; b=g3fhc+9/3rzTBc7S9lPsYPiFPLGJmDH9TSLSJM05jJNR7XNIF2OYp2sgxHCzPUfilUz2dtij8bUa7zgxt3Yf0KHdvY76njBxsouaDp3Y1JTwef7tiwd1YIeTvRT+dqp6N1vPdwH9hzUcuoLyMMqoUAce+o9Fm4oOJHHswoSeEkE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by IA1PR12MB6412.namprd12.prod.outlook.com (2603:10b6:208:3af::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 16:13:56 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::15e7:2ef7:ccc0:7f52]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::15e7:2ef7:ccc0:7f52%7]) with mapi id 15.20.5769.015; Fri, 4 Nov 2022 16:13:56 +0000 Message-ID: <1f0bec9f-1c88-8fc8-1ea8-14b4c41a163f@amd.com> Date: Fri, 4 Nov 2022 16:13:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] [testsuite] gdb.base/dlmopen: Fix test name and use gdb_attach To: Simon Marchi , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20221104155703.756252-1-lancelot.six@amd.com> <6dab4cb2-c1d5-35d3-a295-9c8a5b4927d8@simark.ca> Content-Language: en-US From: Lancelot SIX In-Reply-To: <6dab4cb2-c1d5-35d3-a295-9c8a5b4927d8@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P250CA0007.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::12) To DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5745:EE_|IA1PR12MB6412:EE_ X-MS-Office365-Filtering-Correlation-Id: a67986a2-51e1-4f51-56b2-08dabe7f92d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: INa/YbT9NXTLb1rKynLTm5E2Xj6Gvvsn0HvO8gbKf7MbsJ8Xv2sI4uv7biG8FxZT7DvuArtNm8/L5tajlN3cYbVyX+tA1jALm5Qqp7CmB80BtvmcRu2jL1BOsYj09s+Yb//xt5ocbujjum/6LLPciqTJP8g0X4MieVnDKmwRXKWmTXQ5SrgdnJSMgzfRLE+hf2phTOeAdyWqaHs23f4g3mDFSokPiohxMFQTBROUwTpweUEhHjtvb3TTAtbIM00IqgC0Ly/oNoE/CEU7ptURbZq6Yd30IWBPuuyx2iGmVUIgrKAltz0BGJSmUukyq3ENqB0zbxdrXUmII/IOp2ZrS1kVfqzk+OecR6riMRxus1mTqY9OT7OWQfOI0d3pzumDF/VAoRslKGdUtUw9ojIglE6Xh8cF1ThTlS4BTanHPW4pqJ2faByYX5Gy54DdyhcdJkZ2QdwfJt5gCN4v7XTX3LQkz+1ZCxabklyEIGBQFUWONQe/eHzzQwSZKalGL46GRieTsHxsrwIM47gQQAvelPwVPguUFU6cGnKnLEiNNg5EJG6kd+sorIQYPI5ibNIxr+phexAULZbSx4e2lA/kI4+/VexWcrN8jwq7UsLIE+qFLIX/VB1sz3upyiu6hX1voxbPzU/kA9gzNdWB8OEMPqs15X8pQBw+BpoFs6a/QWAZGmYiHx9IkDNHeQ/IFd3MCqNCWaLidPAHv4J99zX6Om8Ud3OzLvTx758H843Vnu826plxgIsJ1vAUck7vyItiSITb7ZNW21mgClByinSd38NK2zhZwqyA9io7AIRTdeMdElQ3EvEJmxYW7+zpX9h5S18yxKwZk2DfZ7pdDZvulQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5745.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(366004)(39860400002)(451199015)(31696002)(6486002)(478600001)(86362001)(6666004)(316002)(6506007)(4326008)(2906002)(8676002)(66556008)(36756003)(66946007)(66476007)(186003)(41300700001)(6512007)(31686004)(5660300002)(2616005)(38100700002)(8936002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VExNRzJaeWlZUVJBOTM4S3VlcVYyK29TSzNIL0JKTkEvSFBlU25lSkNTbk9t?= =?utf-8?B?YWdQR2FlZ3VNSStlK28rRWt6dzRzWWhvTWNqenpLREJ2aWtVR1VIY0tkK0xp?= =?utf-8?B?SXRhUUg0dktVNmxvVitOUnpDa1RCZ3J2L2w0NkhWSGpUWEo4ZlM4bFRxN2hQ?= =?utf-8?B?cjlFTUE4YkpQVEtxU0V6QXFBVElEZmRualRYN3JmTU0rMVhXc2sxcEMvYTZr?= =?utf-8?B?MlJWQ2MzZUxPVGI0VVptSlBxU1JWc0lmTkNMRXFPQ0pyMGdydmw0OXlVU1V0?= =?utf-8?B?bWxObGtFaTdCVnlDdjBTNFErUGNNcDh1M2x3Vk9Pd0tncXZwejVTS1JJUGNi?= =?utf-8?B?ai9yVmViRS84Q1Nsdjk3OXZNbk5zUFk0NHU4RWg5eENDSEEzNmUzYTN6cUtS?= =?utf-8?B?djMycW1PazlQakVDUGpJekdIa094SEVlWDZWVGwyVXFjMGFxOE55SmQzUlll?= =?utf-8?B?dUdmaVovVVFnMlZRWFo4SFlZdXovb3I3Nm1SYmdIOXgvSVRoQ0ZUQmF0KzdK?= =?utf-8?B?QW1oR2hlMmx1T0xRTFVYOWxGbUY0M1FQOXdJMUYwd3dtVkpYYVR1SHpqcCsx?= =?utf-8?B?U21sYjhYQitFYnRKYnplQTJrU2V5YVpGK3RzQnZPSkNkcURBVmNSbmN0WlBE?= =?utf-8?B?RTRVSFplRzBibzBqN0hPN25yYmRsZ01VMHpQVkNWbmdqSHltMmQvYnpsODFN?= =?utf-8?B?YXpENUk3R29hWUU0WlB1SVZySW91dlBUa2ZzK2VMNFg0TkxubjB0eTJyWEI2?= =?utf-8?B?YkdNZldxdnNLaWx3UXBFc0JMRVBYbEpYQ1duMXRMYm9xVFNYVHBRNEpWcld0?= =?utf-8?B?UlJ4dDdnb0JrbHhTYWZiVmlIUWk3MlIzQ3RDK2R3SndBNkpwTmx0Zi9aZHNw?= =?utf-8?B?Q2lZL0J3cDdoVVU3bkZ1YTg4ZjBXSUFreFl2MGZDVnBkRmZvV1RpU0ttVS91?= =?utf-8?B?MVEvVEh4STZRN0h3NlZOMEp2Z2tkRnVaWkVycHhpZnFZVmh0V1M0NGxzaVc4?= =?utf-8?B?S3VzYzhzZzFqVmVJa0J6cENmRDJPNEVXNHNNRjkxUm9vUVVteFREQmhseUE4?= =?utf-8?B?QUdIWjBEelJRRUNKQytScVlHTTJYeHM4bm5kbGhtUWxBemJHRk9vbGptdXU3?= =?utf-8?B?YkUzMjNmazZlTlp2NlFyNFRrYlRkRERUVGxCOWcweXJWaWxyVWI2YXkzN2hV?= =?utf-8?B?d0hhRjJHWmMzR0NodWZTZ1ZXQTF5VWMwdkJMYkF6QlFxRHVCd2lGY3M2OWxL?= =?utf-8?B?cWRGSjMxeDBnc3kzMXlIeDcranZoYi9KcTBDSDVvWVorUXo3N0IwOG1VK1dV?= =?utf-8?B?UW9hRTNrVkFyUkgvcWRSOGJncWxrMmEwT3E0VXNCZWdobS90NzdIMXBld1hr?= =?utf-8?B?NkREUjNQWGRINFhDa0pFc3JobkpBbG4xWjd5NzZKaVY5UFdtdDdTZW51TExw?= =?utf-8?B?Y01PMys3STFYQ0MrQzZ6UzJnVytuUGFJU2VlbkJKNXVXbE8wZ0E3NlRCN0Zz?= =?utf-8?B?Tm41Q1FGZmMzajZ2R1VyZERFeVloeUttcW5LMWwyMGhLVEFVRG0vc1FmTHFz?= =?utf-8?B?NE5PZHZFc0F1Mzg4OGw4RFlhRVZtYnZRUjk3L1doSUJJSFFoWmtQSmZLckdz?= =?utf-8?B?VVZWWWhSRkFFOVFtWWN2SVIyL2hhMW9UKzI3NUFzM0ZhTm5BeHVKbjBUZGho?= =?utf-8?B?OHFmSEswaFhPMXdyRzJrZnpIeS9rQ2VVbHRnckZUdUUyVUM3L0JpQzhIelQw?= =?utf-8?B?S1dqSVFZMnc5U2c2czBZOXY5UG9tN25jWXY0MWptRStyaE1FdmdreUhUc20w?= =?utf-8?B?am96MVZJZTJDQ3hxNXkzSEFrdTcrNEZFbFdFY1B1NVpaZDkrd0xnc2xseUdq?= =?utf-8?B?MmMzRytCczZuSFFiMU1uaEdvWlQwaENkaEFxWWxhOTJVaGI4MXNpRXpoSU1I?= =?utf-8?B?OUFSNEFmZktOV0FtZ2JlVjErU1FoZC9ZSFJhVEVmc1U2UFprV3FReDFRZXhs?= =?utf-8?B?eStORWxaVTErSkdYU21aK0tWRlMxS1FXVWlVdzM1Y01pT2tiWUVvM3M4Mm00?= =?utf-8?B?anppWHRjWUQvb210dU9EeUlYemNmaWY3alA1V01DcGx5YWk5SUJwL0lLQS9E?= =?utf-8?B?Rml2ZkFOSUEvN0hSQVFlZ296UzQ2emh4WE85aXROT0pmbWY1ZlZKTEsxWU9x?= =?utf-8?Q?mQetlXD+5HO2IFrGSKTlKyTGTBLqYbxRiXFT/H9AU0Uo?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a67986a2-51e1-4f51-56b2-08dabe7f92d9 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 16:13:56.2999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uwJ1/8m1Kbsit5Y8VhlARhkjqEtw+x8AswuAV240lbvV7XZv3IKzUwf8nNvICn89k+wyqygo4a3HZ+tk9FVKtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6412 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Thanks for the review. > > I would prefer doing an early return: > > if { ![gdb_attach $testpid] } { > return > } > > ... just because it keeps the following code at the original column. I'll change this and push the patch shortly. > But regardless: > > Approved-By: Simon Marchi > > Simon Best, Lancelot.