From: Luis Machado <luis.machado@linaro.org>
To: Pedro Alves <pedro@palves.net>, Simon Marchi <simark@simark.ca>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't drop static function bp locations w/o debug info
Date: Tue, 22 Sep 2020 17:20:05 -0300 [thread overview]
Message-ID: <1f254bd1-e75a-cdf3-e7c6-e89d51216635@linaro.org> (raw)
In-Reply-To: <5aea0e8a-2d19-3fa0-5281-86e41be4b8b9@palves.net>
The new tests are failing for aarch64-linux-gnu on Ubuntu 18.04 (GCC 7.5.0).
The breakpoint location patterns don't seem to be matching. Here's what
I see...
info breakpoint^M
Num Type Disp Enb Address What^M
1 breakpoint keep y <MULTIPLE> ^M
1.1 y 0x0000000000000794 <foo@plt+4>^M
1.2 y 0x00000000000008bc <foo>^M
(gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: info breakpoint
info breakpoint^M
Num Type Disp Enb Address What^M
3 breakpoint keep y <MULTIPLE> ^M
3.1 y 0x0000aaaaaaaaa8bc <foo>^M
3.2 y 0x0000ffffb7fc065c <foo>^M
(gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: at main: info breakpoint
info breakpoint^M
Num Type Disp Enb Address What^M
1 breakpoint keep y <MULTIPLE> ^M
1.1 y 0x00000000000006e4 <foo>^M
1.2 y 0x00000000000006f4 <foo>^M
(gdb) FAIL: gdb.base/msym-bp.exp: debug=0: before run: info breakpoint
info breakpoint^M
Num Type Disp Enb Address What^M
3 breakpoint keep y <MULTIPLE> ^M
3.1 y 0x0000aaaaaaaaa6e4 <foo>^M
3.2 y 0x0000aaaaaaaaa6f4 <foo>^M
(gdb) FAIL: gdb.base/msym-bp.exp: debug=0: at main: info breakpoint
Anything obvious?
On 9/13/20 10:25 AM, Pedro Alves wrote:
> On 6/12/20 8:53 PM, Simon Marchi wrote:
>> On 2020-06-12 3:21 p.m., Pedro Alves wrote:
>>> @@ -4371,21 +4336,54 @@ search_minsyms_for_name (struct collect_info *info,
>>>
>>> if (!minsyms.empty ())
>>
>> You could remove this check and de-indent the rest. If minsyms is empty, the loop
>> will just be skipped over.
>>
>> Otherwise, LGTM.
>
> Thanks, I did that, and merged it now.
>
> Pedro Alves
>
next prev parent reply other threads:[~2020-09-22 20:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 19:21 Pedro Alves
2020-06-12 19:53 ` Simon Marchi
2020-09-13 13:25 ` Pedro Alves
2020-09-22 20:20 ` Luis Machado [this message]
2020-09-24 15:16 ` Pedro Alves
2020-09-24 15:32 ` Luis Machado
2020-09-24 15:35 ` Pedro Alves
2020-09-24 15:44 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f254bd1-e75a-cdf3-e7c6-e89d51216635@linaro.org \
--to=luis.machado@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).