From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by sourceware.org (Postfix) with ESMTPS id C2A3C386F430 for ; Tue, 22 Sep 2020 20:20:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C2A3C386F430 Received: by mail-qt1-x842.google.com with SMTP id c18so16722461qtw.5 for ; Tue, 22 Sep 2020 13:20:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uvusHIMIVZyVdS4jVP47xs5vJotKoM3NdPkQTpuP0FQ=; b=rZKZT/Iyf6OsDyVeVIFb+GCI5rEd7/DUNbzJAwZ91y7Q/9OhRC+s3H2p9B5MRmVP3m ppn4ouRsPp94t0yTv7HnvzgG9b4vnEdAUbZrhgk88dypobw4n6KhDSJ/ac/90hJf1tT6 cDIjwQiqEu6qOLbWuTINPzIB8m+GR1Ik1YXvcPgXvXu+yxTC7UOW8XSsbeesK6s35ZMZ 63bfXZioCCMdg84eeuQrAYwfjX+lvZL01elDeRHjAdvC5ejVS/F5B38tycjb8anyV9w/ WTsKyLKDC0vqAPyx29PX2cs6ef7Ws7+aTDGIVq5+x6bKif30lim9RpIxRRvmSnrSqP2X 5S4A== X-Gm-Message-State: AOAM530CR3bDt+8vjs4NMq73DUEdUFz0h/aNPTCBEoQF6kbC01B8/Ka+ 8o6+cEZVjd+D3foWoYz98coyG6kUAcScfw== X-Google-Smtp-Source: ABdhPJy8vz1yvjg4h5iKpumFmGHfpmvqoETw6zaEcGOg8nYcaERPYMlDVxSbP/3dzTQCYPL+8vnDMg== X-Received: by 2002:ac8:7309:: with SMTP id x9mr1840721qto.302.1600806009963; Tue, 22 Sep 2020 13:20:09 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:9bb9:f0e5:cbd:b3c1:d314? ([2804:7f0:8283:9bb9:f0e5:cbd:b3c1:d314]) by smtp.gmail.com with ESMTPSA id e1sm13401582qtb.0.2020.09.22.13.20.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2020 13:20:09 -0700 (PDT) Subject: Re: [PATCH] Don't drop static function bp locations w/o debug info To: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <20200612192108.11481-1-pedro@palves.net> <22959b69-54bd-012e-4026-feb4f02ac671@simark.ca> <5aea0e8a-2d19-3fa0-5281-86e41be4b8b9@palves.net> From: Luis Machado Message-ID: <1f254bd1-e75a-cdf3-e7c6-e89d51216635@linaro.org> Date: Tue, 22 Sep 2020 17:20:05 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <5aea0e8a-2d19-3fa0-5281-86e41be4b8b9@palves.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2020 20:20:12 -0000 The new tests are failing for aarch64-linux-gnu on Ubuntu 18.04 (GCC 7.5.0). The breakpoint location patterns don't seem to be matching. Here's what I see... info breakpoint^M Num Type Disp Enb Address What^M 1 breakpoint keep y ^M 1.1 y 0x0000000000000794 ^M 1.2 y 0x00000000000008bc ^M (gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: info breakpoint info breakpoint^M Num Type Disp Enb Address What^M 3 breakpoint keep y ^M 3.1 y 0x0000aaaaaaaaa8bc ^M 3.2 y 0x0000ffffb7fc065c ^M (gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: at main: info breakpoint info breakpoint^M Num Type Disp Enb Address What^M 1 breakpoint keep y ^M 1.1 y 0x00000000000006e4 ^M 1.2 y 0x00000000000006f4 ^M (gdb) FAIL: gdb.base/msym-bp.exp: debug=0: before run: info breakpoint info breakpoint^M Num Type Disp Enb Address What^M 3 breakpoint keep y ^M 3.1 y 0x0000aaaaaaaaa6e4 ^M 3.2 y 0x0000aaaaaaaaa6f4 ^M (gdb) FAIL: gdb.base/msym-bp.exp: debug=0: at main: info breakpoint Anything obvious? On 9/13/20 10:25 AM, Pedro Alves wrote: > On 6/12/20 8:53 PM, Simon Marchi wrote: >> On 2020-06-12 3:21 p.m., Pedro Alves wrote: >>> @@ -4371,21 +4336,54 @@ search_minsyms_for_name (struct collect_info *info, >>> >>> if (!minsyms.empty ()) >> >> You could remove this check and de-indent the rest. If minsyms is empty, the loop >> will just be skipped over. >> >> Otherwise, LGTM. > > Thanks, I did that, and merged it now. > > Pedro Alves >