From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 8A85E3858D32 for ; Thu, 13 Apr 2023 22:08:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A85E3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33DLhp0Y015323; Thu, 13 Apr 2023 22:08:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding : subject; s=pp1; bh=0fGtLB5Rh34FpQchFqS7u9HjQfj6HSP4Ojhwyx/qObo=; b=esUFp1b0i4EnN5tDdxWBb58EQyFcH8fLx84AS3C+z4N5QpmJOw6R1w7jvseUeEy2Jnfy iUTCImI8GA8gqNAI1h3ejK5K3A+uYT4Ue2wjuQZF965FpvL7TeQFS1iFsg7upzZWZ1Ke DcHX02Bw/k8KHFa4ysYdsguElF5I+5tXAH/pwlqyxXz4OczZr+hYbe53V1ezAW7BXjz4 9STIL59ahD4VJdA8Wh0TVurP2KcSFIjGXS9DSJ6BWbssjI/CWwwEKL4UMnTropHDDW0Z 7bZNDmgGBh3ldnnyv48W1N/5HfGuwHVb8YtA4bJLxM0+/ff26HqOcEFue/qQH31RQq8A iA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pxsa4hr8d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Apr 2023 22:08:34 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33DM10CZ027889; Thu, 13 Apr 2023 22:08:34 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pxsa4hr81-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Apr 2023 22:08:34 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33DK9ED7013521; Thu, 13 Apr 2023 22:08:33 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([9.208.130.100]) by ppma01wdc.us.ibm.com (PPS) with ESMTPS id 3pu0m6wpht-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Apr 2023 22:08:33 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33DM8Vgg14680576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Apr 2023 22:08:31 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4CB555805C; Thu, 13 Apr 2023 22:08:31 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A470358059; Thu, 13 Apr 2023 22:08:30 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.150.219]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 13 Apr 2023 22:08:30 +0000 (GMT) Message-ID: <1f37da062f995a22ff5d447ad339f83333cabca8.camel@us.ibm.com> From: Carl Love To: Tom Tromey , cel@us.ibm.com Cc: gdb-patches@sourceware.org, Ulrich Weigand , Kevin Buettner Date: Thu, 13 Apr 2023 15:08:30 -0700 In-Reply-To: <877cufyacm.fsf@tromey.com> References: <184c0edcf067acccdf71d4dcdd66447bb5d93d4c.camel@us.ibm.com> <1b5d214a6208c422963e58c27c98f81af9601628.camel@us.ibm.com> <87fs936f1o.fsf@tromey.com> <33972784460b21164a6581664f647c4edc03c1f9.camel@us.ibm.com> <2f7fcd02125e3310fb1fe981a2ab9c50597bb057.camel@us.ibm.com> <877cufyacm.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: bQRdGdNCExBM59A2mbsZt613eN7z3wJT X-Proofpoint-GUID: 09IjisPIMf3lsqFKbiz5AqTobT7OMNAJ Subject: RE: [PATCH ver 2] PowerPC: fix _Float128 type output string X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-13_16,2023-04-13_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 adultscore=0 mlxlogscore=484 priorityscore=1501 phishscore=0 clxscore=1015 suspectscore=0 malwarescore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304130196 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom: On Thu, 2023-04-13 at 11:12 -0600, Tom Tromey wrote: > Carl> The function is declared extern in gdb/arch-utils.h b/gdb/arch- > utils.h. > Carl> Thus it can not be declared static as well. > > Surely only the default implementation has to be declared there? > IIUC this particular one is only used by ppc. Sorry, I kept thinking of the default function. Had that stuck in my head. The extern definition for function linux_dwarf2_omit_typedef_p () in gdb/ppc-tdep.h is not needed as it is only used for PowerPC. The function linux_dwarf2_omit_typedef_p() in gdb/ppc-linux-tdep.c can be made static once the extern declaration in gdb/ppc-tdep.h is removed. Sorry for the confusion. Carl