From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by sourceware.org (Postfix) with ESMTPS id D561E3841887 for ; Wed, 1 Jun 2022 14:17:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D561E3841887 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f43.google.com with SMTP id q21so2580902wra.2 for ; Wed, 01 Jun 2022 07:17:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1cXcUIoBuuITZxpjzEt7W/E3sGRXbHxkOLxYQSeZqZU=; b=Ptbx0vNa+SKpkbnHsIpaBH3qR4IJzm0hnE6N9w6UL3LYuiqtIZsEQRQwwRN+lTIukV JtmVRZpzmBy93tmqHk9IskjztWd8KHNVF80xhAV/Hn+4S0ndyYY1MUZTUV0dyyGkU2pK u1SbPShyXUSbpWGgrxd/ibdiYgwo/9n+DTwg0zWE9/i3Fy+ipUO0f2prmozn05uL904G scK1YyWdxr/7r9ezX/OTS9tpqMIjgXGP/wkDmDpHkugX1H3T7OlE9wJzamoGlF3QNPCQ Na8NxIih/K61FR85i8kRlOIItNJjNbgjc5b2sfTFjfj7/GQ0X9V64Vl+xY0i/mLqInBk 2/PA== X-Gm-Message-State: AOAM530s0KlVa1l2Q90RE6ynEstwblXCNeZCeEPWSpykrFgCoNyXDr/2 9JJ5cwLkI4oXjyT9VP7JCUg= X-Google-Smtp-Source: ABdhPJwfQOYIz/qq+9/8RDz7k7bP2O6HJ2XzNTzn50RLCuLDi0Ya824MfGTdFpcSUriLK9JLX6uCeg== X-Received: by 2002:a5d:64c1:0:b0:20f:d995:f896 with SMTP id f1-20020a5d64c1000000b0020fd995f896mr51056wri.180.1654093040711; Wed, 01 Jun 2022 07:17:20 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id l9-20020a05600c27c900b003942a244ecbsm2090100wmb.16.2022.06.01.07.17.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 07:17:19 -0700 (PDT) Message-ID: <1f6a7792-204f-fda1-dc60-b463863daa76@palves.net> Date: Wed, 1 Jun 2022 15:17:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3] gdb: Do not add const sections to the section map Content-Language: en-US To: Ilya Leoshkevich , Tom Tromey , Andrew Burgess Cc: Ulrich Weigand , Andreas Arnez , gdb-patches@sourceware.org References: <20220601120821.2866246-1-iii@linux.ibm.com> From: Pedro Alves In-Reply-To: <20220601120821.2866246-1-iii@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2022 14:17:23 -0000 On 2022-06-01 13:08, Ilya Leoshkevich wrote: > can never return any of these sections: their size is 0, so they cannot > be accepted by bsearch_cmp(). Would it make sense to make insert_section_p skip any section with size=0 instead, then?