From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 200FE3858CDA for ; Mon, 6 Jun 2022 12:45:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 200FE3858CDA Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-424-gsvvxxqaOeODK_Ek2tP25Q-1; Mon, 06 Jun 2022 08:45:55 -0400 X-MC-Unique: gsvvxxqaOeODK_Ek2tP25Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 81814833973 for ; Mon, 6 Jun 2022 12:45:55 +0000 (UTC) Received: from [10.97.116.36] (ovpn-116-36.gru2.redhat.com [10.97.116.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D14740CFD0A for ; Mon, 6 Jun 2022 12:45:54 +0000 (UTC) Message-ID: <1f704329-beee-559e-f289-00799179469a@redhat.com> Date: Mon, 6 Jun 2022 09:45:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PINGv5] [PATCH v4 0/2] [gdb] untie and validate inheritance location From: Bruno Larsen To: "gdb-patches@sourceware.org" References: <20220427122847.233260-1-blarsen@redhat.com> <749a6b66-96b3-a232-bb9b-99517b0b3ae7@redhat.com> <4c1ce56e-a77e-af69-855a-737788fbca08@redhat.com> In-Reply-To: <4c1ce56e-a77e-af69-855a-737788fbca08@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2022 12:45:58 -0000 ping! Cheers! Bruno Larsen On 5/30/22 08:15, Bruno Larsen wrote: > ping > > Cheers! > Bruno Larsen > > On 5/24/22 08:26, Bruno Larsen wrote: >> ping >> >> Cheers! >> Bruno Larsen >> >> On 5/18/22 08:24, Bruno Larsen wrote: >>> ping >>> >>> Cheers! >>> Bruno Larsen >>> >>> On 5/11/22 08:12, Bruno Larsen wrote: >>>> Ping >>>> >>>> Cheers! >>>> Bruno Larsen >>>> >>>> On 4/27/22 09:28, Bruno Larsen wrote: >>>>> Changelog for v4: >>>>>    * rebased on master >>>>>    * removed unnecessary checking after Simon's patch >>>>> >>>>> This started with what was thought of as an incorrect inheritance >>>>> location expression, but turned out to be a correct, but unusual >>>>> expression, and uncovered an incorrect assumption when calculating >>>>> offsets of baseclasses. >>>>> >>>>> This patchset is the new iteration of that solution, that changed >>>>> gnuv3_baseclass_offset calculation to allow for non-virtual inheritance >>>>> that has a non-trivial location expression and also moved the basic >>>>> validation to this function. The check in value_contents_copy_raw was >>>>> changed to an assert. >>>>> Finally, the test was expanded to have one incorrect trivial location, >>>>> and two non-trivial location expressions, one correct and one incorrect. >>>>> >>>>> Bruno Larsen (2): >>>>>    [gdb] Untied inheritance virtuality and loc kind >>>>>    [gdb] Add Simple offset validation when calculating baseclass_offset >>>>> >>>>>   gdb/gnu-v3-abi.c                              |  24 +- >>>>>   .../gdb.dwarf2/dw2-inheritance-locexpr-1.exp  | 233 +++++++++++++++++ >>>>>   .../gdb.dwarf2/dw2-inheritance-locexpr-2.exp  | 235 ++++++++++++++++++ >>>>>   .../gdb.dwarf2/dw2-inheritance-locexpr.c      |  69 +++++ >>>>>   gdb/value.c                                   |   8 +- >>>>>   5 files changed, 562 insertions(+), 7 deletions(-) >>>>>   create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-inheritance-locexpr-1.exp >>>>>   create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-inheritance-locexpr-2.exp >>>>>   create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-inheritance-locexpr.c >>>>>