From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5420 invoked by alias); 1 Dec 2016 11:08:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5408 invoked by uid 89); 1 Dec 2016 11:08:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=outputting, 3014 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Dec 2016 11:08:55 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3873110791; Thu, 1 Dec 2016 11:08:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB1B8qde021036; Thu, 1 Dec 2016 06:08:53 -0500 From: Pedro Alves Subject: Re: [PATCH v2 8/8] Fixup testcases outputting own name as a test name and standardize failed compilation messages To: Luis Machado , gdb-patches@sourceware.org References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <1480107244-1484-9-git-send-email-lgustavo@codesourcery.com> Message-ID: <1f9fc5bc-7390-9734-f2ab-36b68e7f725b@redhat.com> Date: Thu, 01 Dec 2016 11:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480107244-1484-9-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00021.txt.bz2 I thought I had sent this yesterday, but I now see I haven't.. On 11/25/2016 08:54 PM, Luis Machado wrote: > --- a/gdb/testsuite/gdb.base/info-shared.exp > +++ b/gdb/testsuite/gdb.base/info-shared.exp > @@ -31,13 +31,13 @@ set define2 -DSHLIB2_NAME=\"$binfile_lib2\" > > if { [gdb_compile_shlib $srcfile_lib1 $binfile_lib1 \ > [list additional_flags=-fPIC]] != "" } { > - untested "could not compile $binfile_lib1." > + untested "failed to compile shared library" > return -1 > } > > if { [gdb_compile_shlib $srcfile_lib2 $binfile_lib2 \ > [list additional_flags=-fPIC]] != "" } { > - untested "could not compile $binfile_lib2." > + untested "failed to compile shared library" > return -1 Duplicate test message. Write something like: untested "failed to compile shared library 1" untested "failed to compile shared library 2" Another example (though unlike the above, this case was already duplicate): > --- a/gdb/testsuite/gdb.base/attach.exp > +++ b/gdb/testsuite/gdb.base/attach.exp > @@ -30,14 +30,14 @@ remote_exec build "rm -f ${binfile} ${binfile2}" > # build the first test case > # > if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { > - untested attach.exp > + untested "failed to compile" > return -1 > } untested "failed to compile first test case" > > # Build the in-system-call test > > if { [gdb_compile "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable {debug}] != "" } { > - untested attach.exp > + untested "failed to compile" untested "failed to compile in-system-call test" There are likely more instances in the patch. Since you're now reusing the same string on all tests, I think it should be easy to grep (+sort+uniq) for "failed to compile" to catch them. Could you do that? Thanks, Pedro Alves