From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=yqbt=32=simark.ca=simark@sourceware.org>
Received: from simark.ca (simark.ca [158.69.221.121])
	by sourceware.org (Postfix) with ESMTPS id 981843858296
	for <gdb-patches@sourceware.org>; Sat, 26 Nov 2022 20:32:41 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 981843858296
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca
Received: from [10.0.0.11] (unknown [217.28.27.60])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPSA id 1B4C91E112;
	Sat, 26 Nov 2022 15:32:40 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail;
	t=1669494761; bh=BOWUuW4h1Z3wWYYItLfvg+6uqGQkK6NILXeAWef01sM=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=AbKsjhG9+mduZf0/inD0P2kw5Iz7pZaI+x1GdAAkt0Mzz/gMAdscQ0yr7gg+/8aup
	 fPh1Kjn1yI9tqlqTXw0jxuok1BSiMF/uCEWCgRsBaH4+2ZaQnzvVuyVSdXyzv/tRaV
	 5NHEvhV2NS0vtziqjytUVlBvLXXcCqBcWGZROPIg=
Message-ID: <1ff352e2-7e07-a818-01ff-3004142a1eef@simark.ca>
Date: Sat, 26 Nov 2022 15:32:40 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] Remove reset_ecs
Content-Language: en-US
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
References: <20221121175830.3585569-1-tom@tromey.com>
 <102b6335-e33d-ffc0-b7a5-fd79d4cf26af@simark.ca> <87edtqbhx7.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <87edtqbhx7.fsf@tromey.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>


> diff --git a/gdb/infrun.c b/gdb/infrun.c
> index 96346e1f25b..248b71a053b 100644
> --- a/gdb/infrun.c
> +++ b/gdb/infrun.c
> @@ -1854,55 +1854,33 @@ displaced_step_finish (thread_info *event_thread, enum gdb_signal signal)
>     discarded between events.  */
>  struct execution_control_state
>  {
> -  execution_control_state ()
> +  explicit execution_control_state (thread_info *thr = nullptr)
> +    : ptid (thr == nullptr ? null_ptid : thr->ptid),
> +      event_thread (thr),
> +      ws (target_waitstatus ())

Not sure, but I feel like setting ws like this is unnecessary.  It will
be default-constructed the same way if we specify nothing, I believe.

In any case:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon