From: Simon Marchi <simon.marchi@polymtl.ca>
To: Lancelot SIX <lsix@lancelotsix.com>,
Andreas Schwab <schwab@linux-m68k.org>
Cc: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [PR gdb/27614] gdb-add-index fails on symlinks.
Date: Thu, 25 Mar 2021 10:50:49 -0400 [thread overview]
Message-ID: <1ff9524a-9d9d-4a30-1e0d-7712ea10dab5@polymtl.ca> (raw)
In-Reply-To: <20210325142703.GA9731@gwenhwyvar>
On 2021-03-25 10:27 a.m., Lancelot SIX via Gdb-patches wrote:
> On Thu, Mar 25, 2021 at 10:15:26AM +0100, Andreas Schwab wrote:
>> On Mär 25 2021, Lancelot SIX via Gdb-patches wrote:
>>
>>> +if test -L "$1"; then
>>> + # This script will most likely fail if the argument is a symlink to a
>>> + # program. In order to avoid that, try to follow the symlink. However,
>>> + # readlink is not a standard POSIX tool so we have to check if it is
>>> + # available.
>>> + if command -v readlink &>/dev/null; then
>>
>> &> isn't standard shell.
>
> Thanks for spotting it. I’ll change it to '2>&1 >/dev/null'.
In my experience, shellcheck is very good at spotting these non-standard
things (and much more). It could be worth making the file
shellcheck-clean and ensure it stays that way.
Simon
prev parent reply other threads:[~2021-03-25 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 0:43 Lancelot SIX
2021-03-25 9:15 ` Andreas Schwab
2021-03-25 14:27 ` Lancelot SIX
2021-03-25 14:50 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ff9524a-9d9d-4a30-1e0d-7712ea10dab5@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).