public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* Cleanup mi-async.exp
@ 2010-01-20 14:56 Vladimir Prus
  0 siblings, 0 replies; only message in thread
From: Vladimir Prus @ 2010-01-20 14:56 UTC (permalink / raw)
  To: gdb-patches


Pedro has noticed that mi-async.exp test is checking for 'async' target,
which was eliminated quite some time ago. It appears that further, that
tests always runs natively, no matter what target the rest of GDB is
using. So, I've checked in the following patch to clean up things.

- Volodya

Index: ChangeLog                                                            
===================================================================         
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v                            
retrieving revision 1.2095                                                  
diff -u -p -r1.2095 ChangeLog                                               
--- ChangeLog   19 Jan 2010 20:31:37 -0000      1.2095                      
+++ ChangeLog   20 Jan 2010 14:53:50 -0000                                  
@@ -1,3 +1,8 @@
+2010-01-20  Vladimir Prus  <vladimir@codesourcery.com>
+
+       * gdb.mi/mi-async.exp: Remove check for 'async' target, because
+       that target was removed, and the test always runs native anyway.
+
 2010-01-19  Jan Kratochvil  <jan.kratochvil@redhat.com>

        * gdb.base/watchpoint-cond-gone.exp, gdb.base/watchpoint-cond-gone.c,
Index: gdb.mi/mi-async.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-async.exp,v
retrieving revision 1.10
diff -u -p -r1.10 mi-async.exp
--- gdb.mi/mi-async.exp 1 Jan 2010 07:32:03 -0000       1.10
+++ gdb.mi/mi-async.exp 20 Jan 2010 14:53:50 -0000
@@ -17,10 +17,11 @@
 # Test asynchronous Machine Interface (MI) responses.
 #

-# This currently only works with native linux and the async remote protocol.
-if { !([isnative] && [istarget *-linux*]) \
-     && (![target_info exists gdb_protocol] \
-         || [target_info gdb_protocol] != "async") } then {
+# Because of the way this test is written, using 'start' and not using
+# mi_run_cmd, it ignores whatever target the rest of GDB testsuite is
+# using, and always tries to run natively.  So, don't do anything unless
+# we're actually testing native.
+if { !([isnative] && [istarget *-linux*]) } then {
   return
 }



- Volodya

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-20 14:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-20 14:56 Cleanup mi-async.exp Vladimir Prus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).