[PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets

[PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets

[Mike Frysinger]

From: Jie Zhang <jie@codesourcery.com>

Rather than relying on the default remotetimeout value (which might be too
small for some slower devices), use the existing gdb_load_timeout config
option to set it.

Signed-off-by: Jie Zhang <jie@codesourcery.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
2010-03-14  Jie Zhang  <jie@codesourcery.com>

	* gdb/testsuite/config/monitor.exp (gdb_load): New decimal variable.
	Save remotetimeout setting in oldremotetimeout.  Set remotetimeout to
	$loadtimeout.  Restore when done.

 gdb/testsuite/config/monitor.exp |   47 +++++++++++++++++++++++++++++++++++++-
 1 files changed, 46 insertions(+), 1 deletions(-)

diff --git a/gdb/testsuite/config/monitor.exp b/gdb/testsuite/config/monitor.exp
index 9a9c0d1..cd29370 100644
--- a/gdb/testsuite/config/monitor.exp
+++ b/gdb/testsuite/config/monitor.exp
@@ -138,6 +138,7 @@ proc gdb_load { arg } {
     global gdb_prompt
     global timeout
     global last_gdb_file;
+    global decimal
 
     if { $arg == "" } {
 	if [info exists last_gdb_file] {
@@ -226,6 +227,32 @@ proc gdb_load { arg } {
 		set loadtimeout 1600
 	    }
 
+	    if [is_remote target] {
+		send_gdb "show remotetimeout\n"
+		gdb_expect {
+		    -re "Timeout limit to wait for target to respond is ($decimal).*$gdb_prompt $" {
+			set oldremotetimeout $expect_out(1,string);
+		    }
+		    timeout {
+			if { $verbose > 1 } {
+			    perror "Timed out trying to get remotetimeout."
+			}
+		    }
+		}
+		send_gdb "set remotetimeout $loadtimeout\n";
+		gdb_expect {
+		    -re "$gdb_prompt $" {
+			verbose "Set remotetimeout to $loadtimeout\n"
+		    }
+		    timeout {
+			if { $verbose > 1 } {
+			    perror "Timed out trying to set remotetimeout."
+			}
+		    }
+		}
+	    }
+
+	    set load_ok 0
 	    send_gdb $command;
 	    gdb_expect $loadtimeout {
 		-re "\[Ff\]ailed.*$gdb_prompt $" {
@@ -235,7 +262,7 @@ proc gdb_load { arg } {
 		}
 		-re "$gdb_prompt $" {
 		    verbose "Loaded $farg into $GDB\n"
-		    return 0;
+		    set load_ok 1
 		}
 		timeout {
 		    if { $verbose > 1 } {
@@ -243,6 +270,24 @@ proc gdb_load { arg } {
 		    }
 		}
 	    }
+
+	    if [is_remote target] {
+		send_gdb "set remotetimeout $oldremotetimeout\n";
+		gdb_expect {
+		    -re "$gdb_prompt $" {
+			verbose "Set remotetimeout to $oldremotetimeout\n"
+		    }
+		    timeout {
+			if { $verbose > 1 } {
+			    perror "Timed out trying to set remotetimeout."
+			}
+		    }
+		}
+	    }
+
+	    if { $load_ok == 1 } {
+		return 0;
+	    }
 	}
 
 	# Make sure we don't have an open connection to the target.
-- 
1.7.0

Re: [PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets

[Joel Brobecker]

> 	* gdb/testsuite/config/monitor.exp (gdb_load): New decimal variable.
> 	Save remotetimeout setting in oldremotetimeout.  Set remotetimeout to
> 	$loadtimeout.  Restore when done.

Do you have to use send_gdb/gdb_expect in this file, or can you use
gdb_test, or gdb_test_multiple?

Watch out for stray semicolon at the end of a few statements. Eg:

> +             send_gdb "set remotetimeout $oldremotetimeout\n";
                                                               ^^^

-- 
Joel

Re: [PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets

[Jie Zhang]

Mike,

On 03/15/2010 06:02 AM, Mike Frysinger wrote:
> From: Jie Zhang<jie@codesourcery.com>
>
> Rather than relying on the default remotetimeout value (which might be too
> small for some slower devices), use the existing gdb_load_timeout config
> option to set it.
>
> Signed-off-by: Jie Zhang<jie@codesourcery.com>
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> ---
> 2010-03-14  Jie Zhang<jie@codesourcery.com>
>
> 	* gdb/testsuite/config/monitor.exp (gdb_load): New decimal variable.
> 	Save remotetimeout setting in oldremotetimeout.  Set remotetimeout to
> 	$loadtimeout.  Restore when done.
>
I think this patch is not needed for Blackfin now. I believe any 
testcase in GDB can be loaded via gnICE in seconds now.


Jie

Re: [PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets

[Jie Zhang]

On 03/15/2010 08:42 AM, Joel Brobecker wrote:
>> 	* gdb/testsuite/config/monitor.exp (gdb_load): New decimal variable.
>> 	Save remotetimeout setting in oldremotetimeout.  Set remotetimeout to
>> 	$loadtimeout.  Restore when done.
>
> Do you have to use send_gdb/gdb_expect in this file, or can you use
> gdb_test, or gdb_test_multiple?
>
> Watch out for stray semicolon at the end of a few statements. Eg:
>
>> +             send_gdb "set remotetimeout $oldremotetimeout\n";
>                                                                 ^^^
I will see if I can find some time later today to fix these. Thanks for 
review.

-- 
Jie Zhang
CodeSourcery
(650) 331-3385 x735

Re: [PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 994 bytes --]

On Sunday 14 March 2010 21:52:11 Jie Zhang wrote:
> On 03/15/2010 06:02 AM, Mike Frysinger wrote:
> > From: Jie Zhang<jie@codesourcery.com>
> > 
> > Rather than relying on the default remotetimeout value (which might be
> > too small for some slower devices), use the existing gdb_load_timeout
> > config option to set it.
> > 
> > Signed-off-by: Jie Zhang<jie@codesourcery.com>
> > Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> > ---
> > 2010-03-14  Jie Zhang<jie@codesourcery.com>
> > 
> > 	* gdb/testsuite/config/monitor.exp (gdb_load): New decimal variable.
> > 	Save remotetimeout setting in oldremotetimeout.  Set remotetimeout to
> > 	$loadtimeout.  Restore when done.
> 
> I think this patch is not needed for Blackfin now. I believe any
> testcase in GDB can be loaded via gnICE in seconds now.

yes, your work on the gnICE/gnICE+ means the slow loading is a thing of the 
past, but i think your changes here are reasonable and address a real problem
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 246 bytes --]

On Sunday, June 05, 2011 17:34:38 Mike Frysinger wrote:
> Rather than relying on the default remotetimeout value (which might be too
> small for some slower devices), use the existing gdb_load_timeout config
> option to set it.

any love ?
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets

[Mike Frysinger]

From: Jie Zhang <jie.zhang@analog.com>

Rather than relying on the default remotetimeout value (which might be too
small for some slower devices), use the existing gdb_load_timeout config
option to set it.

Signed-off-by: Jie Zhang <jie.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 gdb/testsuite/config/monitor.exp |   47 +++++++++++++++++++++++++++++++++++++-
 1 files changed, 46 insertions(+), 1 deletions(-)

diff --git a/gdb/testsuite/config/monitor.exp b/gdb/testsuite/config/monitor.exp
index be98f1a..9efaf39 100644
--- a/gdb/testsuite/config/monitor.exp
+++ b/gdb/testsuite/config/monitor.exp
@@ -138,6 +138,7 @@ proc gdb_load { arg } {
     global gdb_prompt
     global timeout
     global last_gdb_file;
+    global decimal
 
     if { $arg == "" } {
 	if [info exists last_gdb_file] {
@@ -226,6 +227,32 @@ proc gdb_load { arg } {
 		set loadtimeout 1600
 	    }
 
+	    if [is_remote target] {
+		send_gdb "show remotetimeout\n"
+		gdb_expect {
+		    -re "Timeout limit to wait for target to respond is ($decimal).*$gdb_prompt $" {
+			set oldremotetimeout $expect_out(1,string);
+		    }
+		    timeout {
+			if { $verbose > 1 } {
+			    perror "Timed out trying to get remotetimeout."
+			}
+		    }
+		}
+		send_gdb "set remotetimeout $loadtimeout\n";
+		gdb_expect {
+		    -re "$gdb_prompt $" {
+			verbose "Set remotetimeout to $loadtimeout\n"
+		    }
+		    timeout {
+			if { $verbose > 1 } {
+			    perror "Timed out trying to set remotetimeout."
+			}
+		    }
+		}
+	    }
+
+	    set load_ok 0
 	    send_gdb $command;
 	    gdb_expect $loadtimeout {
 		-re "\[Ff\]ailed.*$gdb_prompt $" {
@@ -235,7 +262,7 @@ proc gdb_load { arg } {
 		}
 		-re "$gdb_prompt $" {
 		    verbose "Loaded $farg into $GDB\n"
-		    return 0;
+		    set load_ok 1
 		}
 		timeout {
 		    if { $verbose > 1 } {
@@ -243,6 +270,24 @@ proc gdb_load { arg } {
 		    }
 		}
 	    }
+
+	    if [is_remote target] {
+		send_gdb "set remotetimeout $oldremotetimeout\n";
+		gdb_expect {
+		    -re "$gdb_prompt $" {
+			verbose "Set remotetimeout to $oldremotetimeout\n"
+		    }
+		    timeout {
+			if { $verbose > 1 } {
+			    perror "Timed out trying to set remotetimeout."
+			}
+		    }
+		}
+	    }
+
+	    if { $load_ok == 1 } {
+		return 0;
+	    }
 	}
 
 	# Make sure we don't have an open connection to the target.
-- 
1.7.5.3