On Sunday 14 March 2010 21:25:33 Eli Zaretskii wrote:

> > From: Vladimir Prus <vladimir@codesourcery.com>
> > Date: Sun, 14 Mar 2010 12:04:11 +0300
> > 
> > I believe this documents all the changes made by my prior patches. OK?
> 
> Thanks.  A few comments:
> 
> >     MI tracepoints documentation.
> >     
> >     	gdb/doc/
> >     	* gdb.texinfo (GDB/MI Tracepoint): Write it.
> 
> I'll probably get another cold shower for expressing opinions about
> ChangeLog style, but I find this rather un-useful.  Why not
> 
> 	* gdb.texinfo (GDB/MI Tracepoint): Document MI tracepoint
>           commands.
> 
> i.e. without the header line?  Such short entries don't really need
> any summary, they summarize themselves.

The primary reason I use summary line everywhere is that I prefer to see
a list of commits, one per line, with sensible summary, so that I can
quickly pick a commit I care about. This is of course only important
when I am working with git, since cvs does not provide such formatting
style for logs.

I don't particularly care for this commit -- I am unlikely to ever
need it thereafter.

> > +@smallexample
> > +(gdb)
> > +-trace-list-variables
> > +^done,trace-variables=@{nr_rows="1",nr_cols="3",
> > +hdr=[@{width="15",alignment="-1",col_name="name",colhdr="Name"@},
> > +     @{width="11",alignment="-1",col_name="initial",colhdr="Initial"@},
> > +     @{width="11",alignment="-1",col_name="current",colhdr="Current"@}],
> > +body=[variable=@{name="$trace_timestamp",initial="0"@}
> > +      variable=@{name="$foo",initial="10",current="15"@}]@}
> > +(gdb)
> 
> ?? This does not match the documentation: no "name", no "initial", no
> "current"...  What am I missing?

I surely do see "name", "initial" and "current" fields above -- except
that the first variable does not have "current" -- which is OK. Maybe,
it's the "table" that confuses things -- the above hdr/body thing is
exactly what MI calls a table, and only 'body' is the actual content.

Thanks for review -- I have applied other comments pretty much as
written. Here's the revised patch that I plan to commit after the
code patches are in.


Thanks,

-- 
Vladimir Prus
CodeSourcery
vladimir@codesourcery.com
(650) 331-3385 x722