From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27809 invoked by alias); 23 Mar 2010 23:15:07 -0000 Received: (qmail 27799 invoked by uid 22791); 23 Mar 2010 23:15:07 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Mar 2010 23:15:02 +0000 Received: (qmail 21072 invoked from network); 23 Mar 2010 23:15:00 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Mar 2010 23:15:00 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: [RFA] gdbserver support for qCRC: (compare-sections) Date: Tue, 23 Mar 2010 23:15:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: "gdb-patches@sourceware.org" References: <4BA40867.4090703@vmware.com> <201003231832.12355.pedro@codesourcery.com> <4BA94444.6060706@vmware.com> In-Reply-To: <4BA94444.6060706@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003232314.57589.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00803.txt.bz2 On Tuesday 23 March 2010 22:44:20, Michael Snyder wrote: > OK, committed, thanks. The checked in version has a new bug: > + if (strncmp ("qCRC:", own_buf, 5) == 0) > + { > + /* CRC check (compare-section). */ > + char *comma; > + CORE_ADDR base; > + int len; > + unsigned long long crc; > + > + require_running (own_buf); > + base == strtoul (own_buf + 5, &comma, 16); ^^ You meant to make that an assignment, not a comparison. Thou shall always test what you commit. ;-) > + if (*comma++ != ',') > + { -- Pedro Alves