From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>
Subject: Re: [RFA] gdbserver support for qCRC: (compare-sections)
Date: Wed, 24 Mar 2010 00:16:00 -0000 [thread overview]
Message-ID: <201003240016.00750.pedro@codesourcery.com> (raw)
In-Reply-To: <201003232314.57589.pedro@codesourcery.com>
On Tuesday 23 March 2010 23:14:57, Pedro Alves wrote:
> You meant to make that an assignment, not a comparison.
> Thou shall always test what you commit. ;-)
Since I'm all over gdbserver, I went ahead fixed this.
--
Pedro Alves
2010-03-24 Pedro Alves <pedro@codesourcery.com>
* server.c (handle_query): Assign, not compare.
---
gdb/gdbserver/server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: src/gdb/gdbserver/server.c
===================================================================
--- src.orig/gdb/gdbserver/server.c 2010-03-24 00:08:10.000000000 +0000
+++ src/gdb/gdbserver/server.c 2010-03-24 00:09:49.000000000 +0000
@@ -1471,7 +1471,7 @@ handle_query (char *own_buf, int packet_
unsigned long long crc;
require_running (own_buf);
- base == strtoul (own_buf + 5, &comma, 16);
+ base = strtoul (own_buf + 5, &comma, 16);
if (*comma++ != ',')
{
write_enn (own_buf);
next prev parent reply other threads:[~2010-03-24 0:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 23:27 Michael Snyder
2010-03-22 17:59 ` Michael Snyder
2010-03-23 16:26 ` Pedro Alves
2010-03-23 18:16 ` Michael Snyder
2010-03-23 18:32 ` Pedro Alves
2010-03-23 22:44 ` Michael Snyder
2010-03-23 23:15 ` Pedro Alves
2010-03-24 0:16 ` Pedro Alves [this message]
2010-03-24 0:34 ` Michael Snyder
2010-03-24 1:15 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003240016.00750.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).