From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29343 invoked by alias); 24 Mar 2010 00:16:09 -0000 Received: (qmail 29335 invoked by uid 22791); 24 Mar 2010 00:16:08 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Mar 2010 00:16:04 +0000 Received: (qmail 24458 invoked from network); 24 Mar 2010 00:16:02 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Mar 2010 00:16:02 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] gdbserver support for qCRC: (compare-sections) Date: Wed, 24 Mar 2010 00:16:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: Michael Snyder References: <4BA40867.4090703@vmware.com> <4BA94444.6060706@vmware.com> <201003232314.57589.pedro@codesourcery.com> In-Reply-To: <201003232314.57589.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003240016.00750.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00807.txt.bz2 On Tuesday 23 March 2010 23:14:57, Pedro Alves wrote: > You meant to make that an assignment, not a comparison. > Thou shall always test what you commit. ;-) Since I'm all over gdbserver, I went ahead fixed this. -- Pedro Alves 2010-03-24 Pedro Alves * server.c (handle_query): Assign, not compare. --- gdb/gdbserver/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: src/gdb/gdbserver/server.c =================================================================== --- src.orig/gdb/gdbserver/server.c 2010-03-24 00:08:10.000000000 +0000 +++ src/gdb/gdbserver/server.c 2010-03-24 00:09:49.000000000 +0000 @@ -1471,7 +1471,7 @@ handle_query (char *own_buf, int packet_ unsigned long long crc; require_running (own_buf); - base == strtoul (own_buf + 5, &comma, 16); + base = strtoul (own_buf + 5, &comma, 16); if (*comma++ != ',') { write_enn (own_buf);