From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1179 invoked by alias); 26 Mar 2010 18:47:18 -0000 Received: (qmail 1168 invoked by uid 22791); 26 Mar 2010 18:47:17 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Mar 2010 18:47:12 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2QIlBk9022549 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Mar 2010 14:47:11 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2QIl8dX026115 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 26 Mar 2010 14:47:10 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o2QIl8pX021478 for ; Fri, 26 Mar 2010 19:47:08 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o2QIl82W021475 for gdb-patches@sourceware.org; Fri, 26 Mar 2010 19:47:08 +0100 Date: Fri, 26 Mar 2010 18:47:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Fix break-interp.exp without prelink installed #2 Message-ID: <20100326184707.GA21393@host0.dyn.jankratochvil.net> References: <20100326174839.GA17910@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100326174839.GA17910@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00912.txt.bz2 just an IMO-unimportant update - as it is already a native-limited test: set readelf_program [transform readelf] On Fri, 26 Mar 2010 18:48:39 +0100, Jan Kratochvil wrote: Hi, found now in a virtual machine that if you have no /usr/sbin/prelink testsuite produces: FAIL: gdb.base/break-interp.exp: LDprelinkNOdebugNO: unprelink break-interp-LDprelinkNOdebugNO ... # of expected passes 10 # of unexpected failures 6 Fixed it, it runs at least the parts it can + XFAILs the others. /usr/sbin/prelink installed: # of expected passes 1580 /usr/sbin/prelink not installed, no system libraries prelinked: # of expected passes 579 # of expected failures 12 XFAIL: gdb.base/break-interp.exp: LDprelinkNOdebugNO: BINprelinkYESdebugNOpieYES: prelink break-interp-BINprelinkYESdebugNOpieYES (missing /usr/sbin/prelink) /usr/sbin/prelink not installed but some system libraries prelinked - this should not normally happen: # of expected passes 12 # of unexpected failures 5 # of expected failures 1 FAIL: gdb.base/break-interp.exp: LDprelinkNOdebugNO: unprelink break-interp-LDprelinkNOdebugNO (missing /usr/sbin/prelink) (/home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.base/break-interp-LDprelinkNOdebugNO is already prelinked) Tested on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu. Thanks, Jan gdb/testsuite/ 2010-03-26 Jan Kratochvil Cope with missing /usr/sbin/prelink. * gdb.base/break-interp.exp (prelinkNO, prelinkYES) : New. --- a/gdb/testsuite/gdb.base/break-interp.exp +++ b/gdb/testsuite/gdb.base/break-interp.exp @@ -134,6 +134,29 @@ proc prelinkNO {arg {name {}}} { set run [prelinkNO_run $arg] set result [lindex $run 0] set output [lindex $run 1] + if {$result == 1 && [regexp {^(couldn't execute "/usr/sbin/prelink[^\r\n]*": no such file or directory\n?)*$} $output]} { + # Without prelink at lest verify all the binaries do not contain the + # ".gnu.prelink_undo" section so that they are not already prelinked. + set test "$test (missing /usr/sbin/prelink)" + foreach bin [split $arg] { + if [string match "-*" $bin] { + # Skip prelink options. + continue + } + set readelf_program [transform readelf] + set command "exec $readelf_program -WS $bin" + verbose -log "command is $command" + set result [catch $command output] + verbose -log "result is $result" + verbose -log "output is $output" + if {$result != 0 || [string match {* .gnu.prelink_undo *} $output]} { + fail "$test ($bin is already prelinked)" + return 0 + } + } + pass $test + return 1 + } if {$result == 0 && $output == ""} { verbose -log "$name has been now unprelinked" set run [prelinkNO_run $arg] @@ -160,6 +183,14 @@ proc prelinkYES {arg {name ""}} { set result [catch $command output] verbose -log "result is $result" verbose -log "output is $output" + if {$result == 1 && [regexp {^(couldn't execute "/usr/sbin/prelink[^\r\n]*": no such file or directory\n?)*$} $output]} { + set test "$test (missing /usr/sbin/prelink)" + # While we could check if $arg is already prelinked (as if someone + # uninstalls prelink after having the system ld.so prelinked) we cannot + # change its prelinked address. Therefore rather skip the test. + xfail $test + return 0 + } if {$result == 0 && $output == ""} { pass $test return 1