From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12537 invoked by alias); 27 Mar 2010 15:30:31 -0000 Received: (qmail 12528 invoked by uid 22791); 27 Mar 2010 15:30:30 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 27 Mar 2010 15:30:26 +0000 Received: (qmail 27911 invoked from network); 27 Mar 2010 15:30:24 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Mar 2010 15:30:24 -0000 Date: Sat, 27 Mar 2010 15:30:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: hjl.tools@gmail.com, gdb-patches@sourceware.org Subject: Re: PATCH: 3/6 [2nd try]: Add AVX support (i386 changes) Message-ID: <20100327153019.GA16019@caradoc.them.org> Mail-Followup-To: Mark Kettenis , hjl.tools@gmail.com, gdb-patches@sourceware.org References: <20100304180219.GA10826@intel.com> <20100304180408.GA10869@intel.com> <20100304180643.GB10869@intel.com> <20100306222037.GD21133@intel.com> <20100307213153.GA7170@intel.com> <201003112237.o2BMb4XR024283@glazunov.sibelius.xs4all.nl> <6dc9ffc81003111600k66be499cqf6639a07d20f5cce@mail.gmail.com> <201003271454.o2REsujU007688@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201003271454.o2REsujU007688@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00927.txt.bz2 On Sat, Mar 27, 2010 at 03:54:56PM +0100, Mark Kettenis wrote: > Yes, we have done that in the past, but I think we should stop adding > #defines like that. I disagree. The values are available in the kernel and glibc headers, sure. But it takes years before a new define in linux/ptrace.h is widely available, and it is not uncommon for new kernels to enter use faster than that. This way, if someone builds a new GDB with AVX support, and installs a new kernel with AVX support, they don't come to us and ask why AVX support isn't in their GDB. [I agree with everything else in Mark's review.] -- Daniel Jacobowitz CodeSourcery