* [PATCH] sim: tweak usage() function definition
@ 2010-03-29 19:38 Mike Frysinger
2010-03-30 15:51 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2010-03-29 19:38 UTC (permalink / raw)
To: gdb-patches
GCC currently emits this warning:
nrun.c: In function 'usage':
nrun.c:223: warning: old-style function definition
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
2010-03-29 Mike Frysinger <vapier@gentoo.org>
* nrun.c (usage): Use void in definition.
sim/common/nrun.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sim/common/nrun.c b/sim/common/nrun.c
index aad1d8c..e537849 100644
--- a/sim/common/nrun.c
+++ b/sim/common/nrun.c
@@ -219,7 +219,7 @@ main (int argc, char **argv)
}
static void
-usage ()
+usage (void)
{
fprintf (stderr, "Usage: %s [options] program [program args]\n", myname);
fprintf (stderr, "Run `%s --help' for full list of options.\n", myname);
--
1.7.0.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sim: tweak usage() function definition
2010-03-29 19:38 [PATCH] sim: tweak usage() function definition Mike Frysinger
@ 2010-03-30 15:51 ` Tom Tromey
2010-03-30 19:44 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2010-03-30 15:51 UTC (permalink / raw)
To: Mike Frysinger; +Cc: gdb-patches
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> 2010-03-29 Mike Frysinger <vapier@gentoo.org>
Mike> * nrun.c (usage): Use void in definition.
I think this change qualifies as obvious.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sim: tweak usage() function definition
2010-03-30 15:51 ` Tom Tromey
@ 2010-03-30 19:44 ` Mike Frysinger
0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2010-03-30 19:44 UTC (permalink / raw)
To: tromey; +Cc: gdb-patches
[-- Attachment #1: Type: Text/Plain, Size: 348 bytes --]
On Tuesday 30 March 2010 11:51:18 Tom Tromey wrote:
> >>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
> Mike> 2010-03-29 Mike Frysinger <vapier@gentoo.org>
> Mike> * nrun.c (usage): Use void in definition.
>
> I think this change qualifies as obvious.
thanks ... i'm not confident enough yet to make this decision ;)
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-30 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-29 19:38 [PATCH] sim: tweak usage() function definition Mike Frysinger
2010-03-30 15:51 ` Tom Tromey
2010-03-30 19:44 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).