From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71730-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12977 invoked by alias); 2 Apr 2010 17:39:40 -0000
Received: (qmail 12953 invoked by uid 22791); 2 Apr 2010 17:39:38 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Apr 2010 17:39:34 +0000
Received: (qmail 2454 invoked from network); 2 Apr 2010 17:39:32 -0000
Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 2 Apr 2010 17:39:32 -0000
Date: Fri, 02 Apr 2010 17:39:00 -0000
From: Daniel Jacobowitz <dan@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: 6/6 [3rd try]: Add AVX support (gdbserver changes)
Message-ID: <20100402173924.GA5329@caradoc.them.org>
Mail-Followup-To: "H.J. Lu" <hjl.tools@gmail.com>, 	GDB <gdb-patches@sourceware.org>
References: <20100304180219.GA10826@intel.com>  <20100304180408.GA10869@intel.com>  <20100304180748.GC10869@intel.com>  <20100304180901.GD10869@intel.com>  <20100304181003.GE10869@intel.com>  <20100306222250.GG21133@intel.com>  <20100312172541.GB6643@intel.com>  <20100329010935.GA27237@intel.com>  <20100330164833.GB13521@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100330164833.GB13521@intel.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00049.txt.bz2

On Tue, Mar 30, 2010 at 09:48:33AM -0700, H.J. Lu wrote:
> OK to install?

Pretty much OK.

> +#ifdef __x86_64__
> +  if (num_xmm_registers == 8)
> +    init_registers_i386_linux ();
> +  else
> +    init_registers_amd64_linux ();
> +#else
> +  init_registers_i386_linux ();
> +#endif

...

> +  /* Update gdbserver_xmltarget with XML support.  */
> +#ifdef __x86_64__
> +  if (num_xmm_registers == 8)
> +    gdbserver_xmltarget = "i386-linux.xml";
> +  else
> +    gdbserver_xmltarget = "amd64-linux.xml";
> +#else
> +  gdbserver_xmltarget = "i386-linux.xml";
> +#endif

Isn't the second block redundant with the first block?

> +/* Process qSupported query, "xmlRegisters=".  Update the buffer size for
> +   PTRACE_GETREGSET.  */
> +
> +static void
> +x86_linux_process_qsupported (const char *query)
> +{
> +  /* Return if gdb doesn't support XML.  If gdb sends "xmlRegisters="
> +     in qSupported query, it supports x86 XML target descriptions.  */
> +  use_xml = query != NULL && strncmp (query, "xmlRegisters=", 13) == 0;
> +
> +  x86_linux_update_xmltarget ();
> +}

Presumably, the protocol-wise correct thing to do would be to
search for "xmlRegisters=" that had an element "x86".

Otherwise OK.

-- 
Daniel Jacobowitz
CodeSourcery