From: Joel Brobecker <brobecker@adacore.com>
To: J?n Stan??ek <jan.stancek@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: patch: fix stack unwind through uClibc syscall() on mips
Date: Wed, 07 Apr 2010 17:11:00 -0000 [thread overview]
Message-ID: <20100407171136.GI19194@adacore.com> (raw)
In-Reply-To: <g2w737ad3551004061155rbe860d16k59029b021da793cf@mail.gmail.com>
> 1. Disassembly
> example is below
Thanks - I actually got myself confused as to where the SP adjustment
happened, so it's good to see the assembly.
> 2. copyright assignment
> I was hoping to fall into this category: "Small changes can be
> accepted without a copyright assignment form on file."
Unfortunately, this one is beyond what can be accepted as a small
change (the guideline is 10-15 lines max).
Overall, I don't know mips well enough and I am a little nervous about
the approach you are taking (it feels too general an approach for such
a specific situation).
Hopefully Daniel can give you more insight?
--
Joel
next prev parent reply other threads:[~2010-04-07 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 17:55 Ján Stanček
2010-04-05 15:45 ` Joel Brobecker
2010-04-06 18:55 ` Ján Stanček
2010-04-07 17:11 ` Joel Brobecker [this message]
2010-04-05 15:51 ` Daniel Jacobowitz
2010-04-06 20:03 ` Ján Stanček
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100407171136.GI19194@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.stancek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).