From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15171 invoked by alias); 7 Apr 2010 17:11:56 -0000 Received: (qmail 15159 invoked by uid 22791); 7 Apr 2010 17:11:54 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Apr 2010 17:11:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C60692BABA7; Wed, 7 Apr 2010 13:11:44 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7V0fveUow+ti; Wed, 7 Apr 2010 13:11:44 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 92B9C2BAB05; Wed, 7 Apr 2010 13:11:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3E5C3F58C2; Wed, 7 Apr 2010 10:11:36 -0700 (PDT) Date: Wed, 07 Apr 2010 17:11:00 -0000 From: Joel Brobecker To: J?n Stan??ek Cc: gdb-patches@sourceware.org Subject: Re: patch: fix stack unwind through uClibc syscall() on mips Message-ID: <20100407171136.GI19194@adacore.com> References: <737ad3551003271055o91a78i3f5ff305b927e441@mail.gmail.com> <20100405154507.GC19194@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00139.txt.bz2 > 1. Disassembly > example is below Thanks - I actually got myself confused as to where the SP adjustment happened, so it's good to see the assembly. > 2. copyright assignment > I was hoping to fall into this category: "Small changes can be > accepted without a copyright assignment form on file." Unfortunately, this one is beyond what can be accepted as a small change (the guideline is 10-15 lines max). Overall, I don't know mips well enough and I am a little nervous about the approach you are taking (it feels too general an approach for such a specific situation). Hopefully Daniel can give you more insight? -- Joel