From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12467 invoked by alias); 26 Apr 2010 16:41:47 -0000 Received: (qmail 12450 invoked by uid 22791); 26 Apr 2010 16:41:45 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Apr 2010 16:41:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 812912BAB63; Mon, 26 Apr 2010 12:41:37 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AWHHTL9Krmpq; Mon, 26 Apr 2010 12:41:37 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4F8222BAAEA; Mon, 26 Apr 2010 12:41:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id F35DFF5896; Mon, 26 Apr 2010 12:41:34 -0400 (EDT) Date: Mon, 26 Apr 2010 16:41:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [vxworks 13/14] Add tdep files for x86 and powerpc. Message-ID: <20100426164134.GC2732@adacore.com> References: <1272210447-13895-1-git-send-email-brobecker@adacore.com> <1272210447-13895-14-git-send-email-brobecker@adacore.com> <201004252044.o3PKiv5G016820@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201004252044.o3PKiv5G016820@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00880.txt.bz2 > > + set_gdbarch_call_dummy_location (gdbarch, ON_STACK); > > +} > > Ugh, that means the stack is executable then isn't it? Yep! I see the whole OS as a very bare version of an OS. There is no concept of a process, so you just start new threads, and every thread just happily run without any barrier from the rest of the system (no virtual memory, no protection from the other threads, etc). It's fine for certain domains, I suppose, but it's weird when you're not used to this sort of thing. > Can you insert a blank line between those functions? With that > change, i386 bits are ok with me. I will do so immediately in the version that we have. Thanks for the review! -- Joel