public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/sparc] "finish" does not work if function returns array.
Date: Sat, 01 May 2010 09:02:00 -0000	[thread overview]
Message-ID: <201005010901.o4191RM8014188@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1272666620-10914-1-git-send-email-brobecker@adacore.com>	(message from Joel Brobecker on Fri, 30 Apr 2010 15:30:20 -0700)

> From: Joel Brobecker <brobecker@adacore.com>
> Date: Fri, 30 Apr 2010 15:30:20 -0700
> 
> This is something that is not explicitly covered by the ABI, which
> would explain why it's not covered by the code yet.  In Ada, functions
> can return arrays, for instance:
> 
>    type Data_Small is array (1 .. 2) of Integer;
>    function Create_Small return Data_Small;

Yeah, it's a serious problem that ABIs only tend to cover the C
language.

>  gdb/sparc-tdep.c   |    7 ++++++-
>  gdb/sparc64-tdep.c |    7 ++++++-
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c
> index a2bae9f..f882505 100644
> --- a/gdb/sparc-tdep.c
> +++ b/gdb/sparc-tdep.c
> @@ -221,7 +221,11 @@ sparc_floating_p (const struct type *type)
>    return 0;
>  }
>  
> -/* Check whether TYPE is "Structure or Union".  */
> +/* Check whether TYPE is "Structure or Union".
> +
> +   In terms of subprogram calls, arrays are treated the same as struct
> +   and union types.  So this function also returns non-zero for array
> +   types.  */

Could you turn that into "In terms of Ada subprogram calls..."?

  reply	other threads:[~2010-05-01  9:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-30 22:30 Joel Brobecker
2010-05-01  9:02 ` Mark Kettenis [this message]
2010-05-02 16:56   ` Joel Brobecker
2010-05-05 17:00     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005010901.o4191RM8014188@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).