public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: one big unit or several smaller units? (was: "Re: Adding support for VxWorks target")
Date: Tue, 04 May 2010 18:30:00 -0000	[thread overview]
Message-ID: <20100504183015.GK2768@adacore.com> (raw)
In-Reply-To: <4BE04081.3090706@codesourcery.com>

[changed the subject for this sub-thread]

> I skimmed, and didn't see anything problematic.

Thanks for looking at them!

> Organizationwise, my personal preference would to be have fewer files
> that are "everything wtx", which in turns reduces the amount of
> headers / header files.  It also forestalls some grumbles about long
> filenames from DOS-land. :-)  But don't feel compelled to glom them
> together, if you prefer multiple files.

It's interesting that you'd say that; I am the total opposite. I don't
mind the extra headers - I think it makes the public/private API clearer.

In fact, funny story: Jerome and I were in NY discussing some recent
breakage in the debugger, and we both said that, while GDB's code has
improved tremendously, some areas are still pretty horrible. After
being asked for examples, I mentioned a few areas, but after a couple
of minutes, Jerome said that one of the worst areas has got to be...
ada-lang! And, oh yeah, it has to be one of the worst... ;-)

And that brings me back to the original thought. I have always wanted
to spend the time to break ada-lang into smaller modules. For instance,
one module to deal with the GNAT encoding and provide a layer that
insulates the rest of the code from it. Another module to handle
expression evaluation. etc.  Given that ada-lang is over 10,000 lines
of code (actually 13,000 lines), I think it's pretty much the only way
I can have a full understanding of that code...

-- 
Joel

  reply	other threads:[~2010-05-04 18:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-25 15:47 Adding support for VxWorks target Joel Brobecker
2010-04-25 15:47 ` [vxworks 01/14] Some ada-lang/ada-tasks routines needed by the " Joel Brobecker
2010-04-25 15:48 ` [vxworks 10/14] Add new "wtx" target Joel Brobecker
2010-04-25 15:48 ` [vxworks 02/14] New command_post observer Joel Brobecker
2010-04-26 18:51   ` Tom Tromey
2010-04-27 14:22     ` Joel Brobecker
2010-04-27 17:16       ` Tom Tromey
2010-04-25 15:48 ` [vxworks 14/14] Configury and Makefile updates for VxWorks Joel Brobecker
2010-04-25 15:48 ` [vxworks 03/14] New module remote-wtx-utils Joel Brobecker
2010-04-26 18:55   ` Tom Tromey
2010-04-27 16:27     ` Joel Brobecker
2010-04-25 15:48 ` [vxworks 08/14] Partition support Joel Brobecker
2010-04-25 15:48 ` [vxworks 11/14] WTX-TCL support module Joel Brobecker
2010-04-25 15:48 ` [vxworks 13/14] Add tdep files for x86 and powerpc Joel Brobecker
2010-04-25 20:45   ` Mark Kettenis
2010-04-26 16:41     ` Joel Brobecker
2010-04-25 15:48 ` [vxworks 09/14] remote-wtx-hw / register fetch/store support Joel Brobecker
2010-04-25 15:56 ` [vxworks 05/14] Add options to control Vxworks related settings Joel Brobecker
2010-05-04 15:25   ` Joel Brobecker
2010-04-25 15:56 ` [vxworks 06/14] VxWorks breakpoint-handling module Joel Brobecker
2010-04-25 15:56 ` [vxworks 07/14] "multi-tasks-mode" support Joel Brobecker
2010-04-25 15:56 ` [vxworks 12/14] Add support for VxWorks 6 Joel Brobecker
2010-04-25 16:01 ` [vxworks 04/14] remote-wtxapi: The WTX API abstraction layer Joel Brobecker
2010-05-04 14:58 ` Adding support for VxWorks target Joel Brobecker
2010-05-04 15:43   ` Stan Shebs
2010-05-04 18:30     ` Joel Brobecker [this message]
2010-11-25  0:53 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100504183015.GK2768@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=stan@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).