public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch] Forbid run with a core file loaded
Date: Fri, 21 May 2010 15:40:00 -0000	[thread overview]
Message-ID: <201005211531.o4LFV6cF022228@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20100521150428.GQ3019@adacore.com> (message from Joel Brobecker	on Fri, 21 May 2010 08:04:28 -0700)

> Date: Fri, 21 May 2010 08:04:28 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > > there is already a protection against loading a core file when a
> > > program is running.
> > 
> > That makes sense.  But what you are suggesting doesn't.
> > 
> > I often start gdb and load a core file to investigate a problem.  Then
> > I set a breakpoint at some point before the crash and run the program
> > again.  This used to work just fine.
> 
> There might have been a poor choice of words in the subject - Based on
> the patch, Jan is not proposing to actually forbid that operation.
> Rather, he's suggesting we add a confirmation query before actually
> restarting the inferior.  Would you agree to such a change?

I'd think that would be pretty pointless.  You don't really lose state
if you use the "run" command.  You can easily get back to looking at
the core file by reloading it using the "core" command.

In general these "Are you sure?" type questions are un-Unixy and
rather annoying in my opinion.  They make sense if the user is about
to take an action that is going to lose state (such as loading a core
file while a program is running), but I think we shouldn't add them in
this case.

  reply	other threads:[~2010-05-21 15:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21 14:47 Jan Kratochvil
2010-05-21 15:02 ` Mark Kettenis
2010-05-21 15:05   ` Joel Brobecker
2010-05-21 15:40     ` Mark Kettenis [this message]
2010-05-23 19:38       ` Jan Kratochvil
2010-05-23 21:08         ` Eli Zaretskii
2010-06-06 19:51           ` Jan Kratochvil
2010-06-06 23:08             ` Eli Zaretskii
2010-06-07 11:21             ` Pedro Alves
2010-06-08  2:33               ` Tom Tromey
2010-06-08 11:03                 ` Pedro Alves
2010-07-08 17:17               ` Jan Kratochvil
2010-07-08 18:28                 ` Eli Zaretskii
2010-07-19 18:02                   ` Jan Kratochvil
2010-07-19 18:05                     ` Eli Zaretskii
2010-07-19 18:16                       ` Jan Kratochvil
2010-07-27 16:00                     ` Joel Brobecker
2010-07-19 14:37                 ` Pedro Alves
2010-05-23 21:16         ` Pedro Alves
2010-05-21 15:05   ` Pedro Alves
2010-05-21 15:54     ` Mark Kettenis
2010-05-21 16:08       ` Pedro Alves
2010-05-21 15:07   ` Jan Kratochvil
2010-05-21 15:04 ` Joel Brobecker
2010-05-21 15:06 ` Pedro Alves
2010-05-21 15:15   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005211531.o4LFV6cF022228@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).