From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13219 invoked by alias); 11 Jun 2010 17:38:09 -0000 Received: (qmail 13208 invoked by uid 22791); 11 Jun 2010 17:38:08 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.17.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jun 2010 17:38:01 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id o5BHbkID029161 for ; Fri, 11 Jun 2010 17:37:46 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5BHbkbe1183838 for ; Fri, 11 Jun 2010 19:37:46 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o5BHbjJH031833 for ; Fri, 11 Jun 2010 19:37:46 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o5BHbi88031827; Fri, 11 Jun 2010 19:37:44 +0200 Message-Id: <201006111737.o5BHbi88031827@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 11 Jun 2010 19:37:44 +0200 Subject: Re: [RFA-v3] Allow explicit 16 or 32 char in 'x /s' To: pierre.muller@ics-cnrs.unistra.fr (Pierre Muller) Date: Fri, 11 Jun 2010 17:38:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, tromey@redhat.com, eliz@gnu.org ('Eli Zaretskii') In-Reply-To: <001201cad75e$2ef3fcc0$8cdbf640$@muller@ics-cnrs.unistra.fr> from "Pierre Muller" at Apr 08, 2010 10:58:03 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00274.txt.bz2 Pierre Muller wrote: > 2010-04-08 Pierre Muller > > * gdb.base/charset.c (Strin16, String32): New variables. > * gdb.base/charset.exp (gdb_test): Test correct display > of 16 or 32 bit strings. > +proc string_display { var_name set_prefix x_size x_type} { > + gdb_test "set ${var_name} = ${set_prefix}\"Test String\\0with zeroes\"" This test required that malloc is present in the inferior; if target code is statically linked, we need to make sure the routine gets pulled in (just like other testcases already do). Tested on spu-elf, committed to mainline. Bye, Ulrich ChangeLog: * gdb.base/charset.c (main): Make sure malloc gets linked in. Index: gdb/testsuite/gdb.base/charset.c =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.c,v retrieving revision 1.13 diff -u -p -r1.13 charset.c --- gdb/testsuite/gdb.base/charset.c 21 Apr 2010 23:21:04 -0000 1.13 +++ gdb/testsuite/gdb.base/charset.c 11 Jun 2010 16:43:07 -0000 @@ -120,6 +120,11 @@ int main () set_debug_traps(); breakpoint(); #endif + + /* charset.exp wants to allocate memory for constants. So make sure malloc + gets linked into the program. */ + malloc (1); + /* Initialize ascii_string. */ init_string (ascii_string, 120, -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com