From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Stan Shebs <stan@codesourcery.com>
Subject: Re: [patch 3/3] bpstat_what removal [rediff]
Date: Fri, 18 Jun 2010 14:09:00 -0000 [thread overview]
Message-ID: <20100618140936.GA24028@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <201006181242.30972.pedro@codesourcery.com>
On Fri, 18 Jun 2010 13:42:30 +0200, Pedro Alves wrote:
> There are code paths in handle_inferior_event that _want_ to resume until
> a breakpoint is rehit, related to (nested) signals. Not sure they apply in
> this case, I/We'll need to dig further. (another reason for wanting to have
> that change separated).
That is very surprising to me, so far I have considered such re-hits as
clearly a bug in handle_inferior_event, not considering other code may expect
it. I agree now my patch went too far and it should be split (like you did).
> > But former BPSTAT_WHAT_STEP_RESUME and BPSTAT_WHAT_SET_LONGJMP_RESUME
> > (therefore those using `keep_going (ecs); return;' make a mess there as they
> > cancel lower priorities wanting to stop.
>
> Well, not cancel, but postpone.
Without of possibility getting some event lost? (watchpoints come to my mind)
Not important now as I see there is an approved plan to remove it anyway.
> I have trouble thinking how you'd have a simultaneous
> BPSTAT_WHAT_STEP_RESUME along with an solib or jit event, but,
There is missing and planned "new invisible breakpoints, with Python code
attached" stated in:
Tom Tromey: Re: [patch 3/3] bpstat_what removal [rediff]
http://sourceware.org/ml/gdb-patches/2010-06/msg00376.html
which can happen for (after re-hits start to be prevented):
call_func_without_debuginfo ();
line_with_python_invisible_breakpoint;
> let's put thread event breakpoints and other kind of event breakpoints we'll
> come up with, or even gdb side tracepoints in the mix.
I assume you mean the case I have described now above.
> All these breakpoints have the property that you do want to
> avoid considering rehits introduced by these "spurious" resumes as separate
> hits. Easier to think about if you consider tracepoints (you'd have double,
> or more collects for the same tracepoint hit), and that does indeed suggest
> something needs to change.
Great there is approval of this intention of re-hits removal.
> The goal was getting the table our of the way, which is supposedly
> a non-behaviour (almost mechanical actually) change, so we can concentrate
> on the interface and infrun issues.
OK, true the table itself is currently the most obvious pain.
> > This violates the goal of my patch to make its reviewing easier by not
> > changing the behavior in any way for the cases only a single event happens.
>
> (while making it hard to review because it changes the behavior when
> multiple breakpoints happen :-) )
... as the (IMO) "obviously broken behavior" is expected by the current code.
Thanks,
Jan
next prev parent reply other threads:[~2010-06-18 14:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 20:02 [patch 3/3] bpstat_what removal Jan Kratochvil
2010-05-04 14:10 ` Stan Shebs
2010-05-07 16:17 ` Jan Kratochvil
2010-05-07 16:26 ` Pedro Alves
2010-05-07 17:02 ` Jan Kratochvil
2010-05-07 17:17 ` Pedro Alves
2010-05-17 21:46 ` Jan Kratochvil
2010-06-12 17:02 ` [patch 3/3] bpstat_what removal [rediff] Jan Kratochvil
2010-06-15 15:08 ` Pedro Alves
2010-06-15 21:54 ` Jan Kratochvil
2010-06-16 19:13 ` Pedro Alves
2010-06-18 10:41 ` Jan Kratochvil
2010-06-18 11:42 ` Pedro Alves
2010-06-18 14:09 ` Jan Kratochvil [this message]
2010-06-18 14:35 ` Pedro Alves
2010-06-24 14:44 ` [patch 3/3] bpstat_what removal Jan Kratochvil
2010-06-24 14:48 ` [patch 3.1/3] bpstat_what removal - addon gdb_assert Jan Kratochvil
2010-06-24 15:03 ` [patch 3/3] bpstat_what removal Pedro Alves
2010-06-24 15:21 ` Jan Kratochvil
2010-06-16 20:40 ` [patch 3/3] bpstat_what removal [rediff] Tom Tromey
2010-06-23 14:42 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100618140936.GA24028@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).