From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Chris Moller <cmoller@redhat.com>
Cc: tromey@redhat.com,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] pr10659 pretty-printing: Display vectors of vectors as matrix--rev 2
Date: Wed, 30 Jun 2010 12:26:00 -0000 [thread overview]
Message-ID: <20100630122610.GA17720@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <4C0407E4.3020604@redhat.com>
On Mon, 31 May 2010 21:03:00 +0200, Chris Moller wrote:
> --- valprint.h 1 Jan 2010 07:31:43 -0000 1.25
> +++ valprint.h 31 May 2010 18:35:09 -0000
> @@ -31,6 +31,9 @@
> /* Controls pretty printing of arrays. */
> int prettyprint_arrays;
>
> + /* Affects pretty printing of matrices. */
> + int prettyprint_matrix;
> +
> /* Controls pretty printing of structures. */
> int prettyprint_structs;
>
This part has massive regression, one sample:
FAIL: gdb.base/break-entry.exp: running to *0x4002e0 in runto
BTW please use -p for CVS diff (this is `struct value_print_options').
Thanks,
Jan
prev parent reply other threads:[~2010-06-30 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 17:46 [patch] pr10659 pretty-printing: Display vectors of vectors as matrix Chris Moller
2010-05-27 21:14 ` Phil Muldoon
2010-05-27 22:25 ` Chris Moller
2010-05-27 21:20 ` Tom Tromey
2010-05-31 23:21 ` [patch] pr10659 pretty-printing: Display vectors of vectors as matrix--rev 2 Chris Moller
2010-06-02 22:58 ` Tom Tromey
2010-06-30 12:26 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630122610.GA17720@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=cmoller@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).