From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22681 invoked by alias); 30 Jun 2010 12:26:23 -0000 Received: (qmail 22669 invoked by uid 22791); 30 Jun 2010 12:26:21 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Jun 2010 12:26:16 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5UCQEci003477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 30 Jun 2010 08:26:14 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5UCQBRg015754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 30 Jun 2010 08:26:13 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o5UCQBeg018968; Wed, 30 Jun 2010 14:26:11 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o5UCQA2T018967; Wed, 30 Jun 2010 14:26:10 +0200 Date: Wed, 30 Jun 2010 12:26:00 -0000 From: Jan Kratochvil To: Chris Moller Cc: tromey@redhat.com, "gdb-patches@sourceware.org" Subject: Re: [patch] pr10659 pretty-printing: Display vectors of vectors as matrix--rev 2 Message-ID: <20100630122610.GA17720@host0.dyn.jankratochvil.net> References: <4BFEA148.7000409@redhat.com> <4C0407E4.3020604@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C0407E4.3020604@redhat.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00692.txt.bz2 On Mon, 31 May 2010 21:03:00 +0200, Chris Moller wrote: > --- valprint.h 1 Jan 2010 07:31:43 -0000 1.25 > +++ valprint.h 31 May 2010 18:35:09 -0000 > @@ -31,6 +31,9 @@ > /* Controls pretty printing of arrays. */ > int prettyprint_arrays; > > + /* Affects pretty printing of matrices. */ > + int prettyprint_matrix; > + > /* Controls pretty printing of structures. */ > int prettyprint_structs; > This part has massive regression, one sample: FAIL: gdb.base/break-entry.exp: running to *0x4002e0 in runto BTW please use -p for CVS diff (this is `struct value_print_options'). Thanks, Jan